Remove unused import and useless conditional expression

[xiaoyang-sde]

Remove unused import:

• MatMenu in src/app/frontend/chrome/userpanel/component.ts
• MatDialogRef in src/app/frontend/common/dialogs/config/dialog.ts
• SecurityContext and DomSanitizer in src/app/frontend/common/pipes/stripansi.ts
• StringMap in src/app/frontend/resource/cluster/persistentvolume/detail/component.ts

Remove useless conditional expression:

• route in src/app/frontend/common/components/breadcrumbs/component.ts

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: xiaoyang-sde / name: Xiaoyang Liu (9b4bfd4)

[k8s-ci-robot]

Welcome @xiaoyang-sde!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[floreks]

Overall, I'd prefer to update the no-unused-vars linter rule to automatically throw errors when unused imports or variables are found.

[xiaoyang-sde]

Overall, I'd prefer to update the no-unused-vars linter rule to automatically throw errors when unused imports or variables are found.

I found that the .eslintrc.yaml file explicitly disabled this rule for some reason. I could try to enable this rule and check if it will introduce unexpected effects.

[floreks]

Ye, I am not sure why it is disabled. Below config should be sufficient:
"@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_"}],

You can remove the generic <T> part from the resource base class (it will be marked by this rule) as it should not be needed.

[xiaoyang-sde]

Thanks. I enabled it in the latest commit!

[maciaszczykm]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, xiaoyang-sde

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment