Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds SIG-specific contributing guides to contributing guide README #3419

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Adds SIG-specific contributing guides to contributing guide README #3419

merged 4 commits into from
Mar 18, 2019

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Mar 13, 2019 •
edited
Loading

Addresses discussion generated in #3414 (comment).
Fixes naming standards for sig windows and sig storage.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@guineveresaenger guineveresaenger mentioned this pull request Mar 13, 2019
Merged
@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Mar 13, 2019
@guineveresaenger guineveresaenger changed the title Adds SIG-specific contributing guides to contributing guide README. Addresses discussion generated in https://github.com/kubernetes/community/pull/3414#issuecomment-472521803. Fixes naming standards for sig windows and sig storage. /cc @michmike /cc @parispittman /sig-contributor-experience /sig-windows /sig-storage Adds SIG-specific contributing guides to contributing guide README Mar 13, 2019
@guineveresaenger
Copy link
Contributor Author

Arg, sorry about that title 😓

/cc @michmike
/cc @parispittman
/sig-contributor-experience
/sig-windows
/sig-storage

michmike
michmike reviewed Mar 13, 2019
View reviewed changes
contributors/guide/README.md
@@ -23,15 +23,15 @@ Welcome to Kubernetes!
- [Find something to work on](#find-something-to-work-on)
- [Find a good first topic](#find-a-good-first-topic)
- [Learn about SIGs](#learn-about-sigs)
- [SIG-specific contributing guidelines](#sig-specific-contributing-guidelines)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the TOC was not generated properly. the Learn about SIGs topic should have 3 children

  1. sig structure
  2. find a sig...
    2.1 SIG-specific contribution guides

something else must be messed up because file an issue has a different heading too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. We hadn't previously been using any headers smaller than those anyway. :/ I'll actually make it a taller heading so the ToC makes sense.

I think File an Issue is the correct level though?

@michmike
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2019
@guineveresaenger
Copy link
Contributor Author

@michmike - PTAL :)

@michmike
Copy link
Contributor

@michmike - PTAL :)

looks good to me and i will approve
one nit. the Find a good first topic and Find something to work on
seem to two related areas that should be merged...but that's for another PR :)

@michmike
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
@guineveresaenger
Copy link
Contributor Author

/assign @parispittman for approval

@k8s-ci-robot
Copy link
Contributor

@guineveresaenger: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @parispittman for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@parispittman
Copy link
Contributor

/approve

thanks @guineveresaenger as always 🎊

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guineveresaenger, michmike, parispittman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@guineveresaenger
Copy link
Contributor Author

/remove hold

@guineveresaenger
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 858950f into kubernetes:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michmike michmike michmike approved these changes

@childsb childsb Awaiting requested review from childsb

@idvoretskyi idvoretskyi Awaiting requested review from idvoretskyi

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@parispittman parispittman

@michmike michmike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guineveresaenger @michmike @k8s-ci-robot @parispittman