Adding the section of contributor guide for sig-windows

[michmike]

No description provided.

[michmike]

/milestone v1.14
/sig windows

[michmike]

/assign castrojo

[michmike]

@nikopen can you please add this to 1.14 milestone?

[guineveresaenger]

Hi @michmike - thank you for this PR! I'm going to take a look at this tomorrow. For now, know that milestones are only enabled on kubernetes/kubernetes, so we won't need to follow release process here.
I'll probably ask you to move some of this content elsewhere to keep concerns streamlined and discoverable, but I'm so excited to see this kind of helpful content. <3

[nikopen]

Indeed milestones are only needed in the core repo.

Structure wise, I'd suggest the contributor guide to be moved within the SIG-Windows directory.

@guineveresaenger On the central 'contributors/guide/readme.md' there should be links to every single SIG's contributor guide so people can easily be directed to a more specific contributing resource.

[michmike]

/hold
until we figure out the structure

[michmike]

Indeed milestones are only needed in the core repo.

Structure wise, I'd suggest the contributor guide to be moved within the SIG-Windows directory.

@guineveresaenger On the central 'contributors/guide/readme.md' there should be links to every single SIG's contributor guide so people can easily be directed to a more specific contributing resource.

that works for me if that's what the central guidance will be

[castrojo]

Wow thanks for this, agree with the rest, have contributing-on-windows.md live in the sig-windows directory. Remove the hold when this is done and then ping me on slack, I'd like to merge this asap before release.

[michmike]

Wow thanks for this, agree with the rest, have contributing-on-windows.md live in the sig-windows directory. Remove the hold when this is done and then ping me on slack, I'd like to merge this asap before release.

i moved and re-arranged the files as requested. how does it look now?

[michmike]

/hold cancel

[craiglpeters]

/lgtm

[castrojo]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [castrojo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[guineveresaenger]

Hi everyone! I have some different thoughts on this, and I literally just started my work day.

1. The SIG-specific contributing doc should be called CONTRIBUTING.md to standardize across the repo (see also: https://github.com/kubernetes/community/blob/master/sig-cli/CONTRIBUTING.md)

2. The generic one-stop contributor guide should not specifically call out any one SIG or area of interest. We link to the SIGs within the guide, and point out that a SIG may have their own contributing guide.

I'm completely open to making these SIG-specific guides more visible via @nikopen's comment, but the contributor guide should not cater to individual SIGs or technologies; it will result in too much clutter.

[parispittman]

@guineveresaenger
#1 - 100% agree
#2 - i think it would be beneficial to have links to other contributing guides on the main one since we have a discoverability issue. This also may make it easier for folks to find a sig.

[michmike]

i agree with @parispittman 100% on 1 and 2. if you are all good with it, i can create a new PR to reflect the new changes

[guineveresaenger]

Hi friends! I'm just working on incorporating this feedback, a new PR will be up momentarily! Thank you for your patience, @michmike :)

[guineveresaenger]

Here it is: #3419

[nikopen]

👍