Skip to content

Support new aws partition in credential provider#1284

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sam-berning:new-partition-support
Oct 27, 2025
Merged

Support new aws partition in credential provider#1284
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sam-berning:new-partition-support

Conversation

@sam-berning
Copy link
Copy Markdown
Contributor

@sam-berning sam-berning commented Oct 27, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

Allows credential provider to recognize a new AWS partition.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 27, 2025
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Oct 27, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: sam-berning / name: Sam Berning (d105cb2)

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims October 27, 2025 17:51
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2025

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2025

Welcome @sam-berning!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2025

Hi @sam-berning. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 27, 2025
@cartermckinnon
Copy link
Copy Markdown
Contributor

cartermckinnon commented Oct 27, 2025

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2025
@cartermckinnon
Copy link
Copy Markdown
Contributor

cartermckinnon commented Oct 27, 2025

@sam-berning you'll need to sign the CLA.

kmala
kmala reviewed Oct 27, 2025
View reviewed changes
cmd/ecr-credential-provider/main.go Outdated
func parseRegionFromECRPrivateHost(host string) string {
splitHost := ecrPrivateHostPattern.FindStringSubmatch(host)
if len(splitHost) != 5 {
if len(splitHost) != 6 {
Copy link
Copy Markdown
Member

@kmala kmala Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not change the pattern which needs this ?

Copy link
Copy Markdown
Contributor Author

@sam-berning sam-berning Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in new revision

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 27, 2025
@sam-berning sam-berning force-pushed the new-partition-support branch from d284d1e to d105cb2 Compare October 27, 2025 18:32
@kmala
Copy link
Copy Markdown
Member

kmala commented Oct 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 27, 2025

@sam-berning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-e2e-kubetest2-quick d105cb2 link false /test pull-cloud-provider-aws-e2e-kubetest2-quick
pull-cloud-provider-aws-e2e-kubetest2 d105cb2 link false /test pull-cloud-provider-aws-e2e-kubetest2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 105f74d into kubernetes:master Oct 27, 2025
9 of 11 checks passed
This was referenced Oct 27, 2025
Closed
Merged
Merged
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2025
@k8s-ci-robot
Merge pull request #1289 from sam-berning/automated-cherry-pick-of-#1…
8a764bf 
…284-upstream-release-1.32

Automated cherry pick of #1284: support new aws partition in credential provider
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2025
@k8s-ci-robot
Merge pull request #1290 from sam-berning/automated-cherry-pick-of-#1…
808a253 
…284-upstream-release-1.33

Automated cherry pick of #1284: support new aws partition in credential provider
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2025
@k8s-ci-robot
Merge pull request #1287 from sam-berning/automated-cherry-pick-of-#1…
574f134 
…284-upstream-release-1.30

Automated cherry pick of #1284: support new aws partition in credential provider
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2025
@k8s-ci-robot
Merge pull request #1288 from sam-berning/automated-cherry-pick-of-#1…
a4e6faf 
…284-upstream-release-1.31

Automated cherry pick of #1284: support new aws partition in credential provider
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2025
@k8s-ci-robot
Merge pull request #1291 from sam-berning/automated-cherry-pick-of-#1…
f011c0f 
…284-upstream-release-1.34

Automated cherry pick of #1284: support new aws partition in credential provider
k8s-ci-robot added a commit that referenced this pull request Oct 28, 2025
@k8s-ci-robot
Merge pull request #1286 from sam-berning/automated-cherry-pick-of-#1…
246ea70 
…284-upstream-release-1.29

Automated cherry pick of #1284: support new aws partition in credential provider
@koooosh koooosh mentioned this pull request Dec 30, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmala kmala kmala left review comments

@bridgetkromhout bridgetkromhout Awaiting requested review from bridgetkromhout

@dims dims Awaiting requested review from dims

Assignees

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sam-berning @k8s-ci-robot @cartermckinnon @kmala