Add k8s-1.35 and ecr-credential-provider-1.35 pkgs with pre-release sources#777
Merged
ytsssun merged 2 commits intobottlerocket-os:developfrom Dec 31, 2025
Merged
Conversation
ddd6009 to
2327d00
Compare
56dd7f7 to
d1119e0
Compare
koooosh
suggested changes
Dec 30, 2025
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
d1119e0 to
473aa56
Compare
koooosh
suggested changes
Dec 31, 2025
Contributor
koooosh
left a comment
There was a problem hiding this comment.
We should fix the Release field for ECR cred provider, but the rest are just nits
packages/ecr-credential-provider-1.35/ecr-credential-provider-1.35.spec
Outdated
Show resolved
Hide resolved
Add ecr-credential-provider for Kubernetes 1.35. Uses cloud-provider-aws v1.35.0 source. Signed-off-by: Yutong Sun <yutongsu@amazon.com>
473aa56 to
398157c
Compare
Contributor
Author
|
Force push to address comments from @koooosh |
koooosh
reviewed
Dec 31, 2025
Signed-off-by: Yutong Sun <yutongsu@amazon.com>
398157c to
d0ef3d3
Compare
koooosh
approved these changes
Dec 31, 2025
Contributor
koooosh
left a comment
There was a problem hiding this comment.
The rpm info for ecr-credential-provider-1.35 needs to be updated in the description since we updated some of the fields, but overall LGTM.
piyush-jena
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Related to: bottlerocket-os/bottlerocket#4725
Description of changes:
Initial set of changes for kubernetes 1.35 support:
Key changes:
--pod-infra-container-imagekubelet flag (removed upstream in 1.35)Testing done:
kubelet version is reported correctly
rpmvercmpTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.