Skip to content

Conversation

@phuhung273
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

VPA Updater add deployment

Which issue(s) this PR fixes:

Relates #8587

Special notes for your reviewer:

Quick test with this vpa.yaml

updater:
  enabled: true
  image:
    repository: registry.k8s.io/autoscaling/vpa-updater
    tag: 1.5.1
    pullPolicy: Always
  podLabels:
    foo: bar
  podAnnotations:
    foo: bar
helm upgrade --install vpa ./vertical-pod-autoscaler/charts/vertical-pod-autoscaler/ \
  -n vpa --create-namespace \
  -f vpa.yaml

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/needs-area needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @phuhung273. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-area labels Oct 22, 2025
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
/lgtm
/assign @adrianmoisey

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2025
@phuhung273
Copy link
Contributor Author

Thanks for your review Omer!

@adrianmoisey
Copy link
Member

Should the updater also get the PDB and lease treatment, similar to the recommender?

See #8646

@omerap12
Copy link
Member

Should the updater also get the PDB and lease treatment, similar to the recommender?

See #8646

Of course ( I thought Hung probably preferred to do that in a followup )

@phuhung273
Copy link
Contributor Author

Should the updater also get the PDB and lease treatment, similar to the recommender?

Yes it should. Im just trying to follow the parent issue to have them separated. Although stuffs like PDB,SA,resources are just few lines change. But i want to keep it easier to review and welcome other contributors.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 23, 2025
@phuhung273 phuhung273 requested a review from omerap12 October 23, 2025 05:58
@adrianmoisey
Copy link
Member

Yes it should. Im just trying to follow the parent issue to have them separated. Although stuffs like PDB,SA,resources are just few lines change. But i want to keep it easier to review and welcome other contributors.

Gotcha, no problem! Thought I'd ask

pullPolicy: IfNotPresent

# Number of Updater replicas to create.
replicas: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only nit I have, is this should be 1 if the lease isn't configured yet
No biggie since this is a pre-stable release, but I think it's good to be correct here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah no worries. Thanks for your review.

@adrianmoisey
Copy link
Member

/ok-to-test
/lgtm

Thanks! The Helm chart is starting to take shape!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2025
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerap12, phuhung273

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit e97bbba into kubernetes:master Oct 23, 2025
8 checks passed
@phuhung273 phuhung273 deleted the updater-deployment branch October 23, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants