-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(chart): VPA Updater deployment #8679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @phuhung273. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
/lgtm
/assign @adrianmoisey
|
Thanks for your review Omer! |
|
Should the updater also get the PDB and lease treatment, similar to the recommender? See #8646 |
Of course ( I thought Hung probably preferred to do that in a followup ) |
Yes it should. Im just trying to follow the parent issue to have them separated. Although stuffs like PDB,SA,resources are just few lines change. But i want to keep it easier to review and welcome other contributors. |
0acea79 to
8e5455f
Compare
Gotcha, no problem! Thought I'd ask |
| pullPolicy: IfNotPresent | ||
|
|
||
| # Number of Updater replicas to create. | ||
| replicas: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only nit I have, is this should be 1 if the lease isn't configured yet
No biggie since this is a pre-stable release, but I think it's good to be correct here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah no worries. Thanks for your review.
8e5455f to
a3cfd07
Compare
Signed-off-by: phuhung273 <[email protected]>
a3cfd07 to
5475274
Compare
|
/ok-to-test Thanks! The Helm chart is starting to take shape! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omerap12, phuhung273 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
VPA Updater add deployment
Which issue(s) this PR fixes:
Relates #8587
Special notes for your reviewer:
Quick test with this
vpa.yamlDoes this PR introduce a user-facing change?