-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(vpa-chart): add chart logic for the vpa recommender #8646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vpa-chart): add chart logic for the vpa recommender #8646
Conversation
|
/release-note-none |
|
I believe you are unblocked now |
|
Sorry, I was on holiday 😅 , I can rebase today. |
813dfe8 to
9b2a83d
Compare
9b2a83d to
9d4e5c5
Compare
|
/unhold |
9d4e5c5 to
f82068f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm
...od-autoscaler/charts/vertical-pod-autoscaler/templates/recommender-leader-election-rbac.yaml
Show resolved
Hide resolved
|
I tested it using the default setup: |
Adds to the VPA helm chart for the recommender: - Deployment - ServiceAccount - RBAC (ClusterRole, RoleBinding) - ConfigMap (optional tuning parameters) - PodDisruptionBudget - nodeSelector / affinity / tolerations - High availibility by default + leader-election logic Signed-off-by: Max Cao <[email protected]>
f82068f to
f4a8aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Max!
/lgtm
/assign @adrianmoisey
|
/approve thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianmoisey, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) this PR fixes:
Part of: #8587
Adds to the VPA helm chart:
For vpa-recommender:
Updates chart version to
0.4.0.What type of PR is this?
/kind feature
You can test it out by using this:
Special notes for your reviewer:
I was mostly just following the existing manifests in
veritcal-pod-autoscaler/deploy/*.yamlDoes this PR introduce a user-facing change?