Remove a category label `needs-*` when the user is defining one #370

danilo-gemoli · 2025-02-04T11:49:41Z

These are the available needs-* categories that can be applied to an issue (see here):

needs-kind, needs-priority, needs-sig, needs-triage

When an issue has one of those, as needs-triage, and the user is defining that category like so:

/triage unresolved

then the needs-triage will be removed.

k8s-ci-robot · 2025-02-04T11:49:46Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danilo-gemoli
Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/plugins/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2025-02-04T11:50:00Z

✅ Deploy Preview for k8s-prow ready!

Name	Link
🔨 Latest commit	`aae1f05`
🔍 Latest deploy log	https://app.netlify.com/sites/k8s-prow/deploys/67a1fed8b763590008976142
😎 Deploy Preview	https://deploy-preview-370--k8s-prow.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

danilo-gemoli · 2025-02-04T14:30:13Z

/retest-required

jmguzik · 2025-02-04T17:36:40Z

pkg/plugins/label/label.go

+//	labels 		:= []string{"triage/unresolved", "area/testing"}
+//	needsLabels := []string{"triage"}
+//	result 		:= []string{"triage"}
+func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] {


Suggested change

func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] {

func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] {

needsLabelsSet := sets.New(needsLabels...)

categories := sets.New[string]()

for _, label := range labels {

if prefix, _, found := strings.Cut(label, "/"); found && needsLabelsSet.Has(prefix) {

categories.Insert(prefix)

}

}

return categories

}

Just for you to consider

Weak -1 from me, I'm a fan of private-unless-proven-to-be-necessary-public 😓

Its my bad. I meant internals of the function, my intention was not to propose to make it public. Let me correct that.

Corrected, again comment is about internals not about publicity, sorry for the confusion.

jmguzik · 2025-02-04T17:39:34Z

Is it in any way related to #344?

petr-muller · 2025-02-04T23:26:00Z

Yeah I'm also curious about the relation to #344 b/c I thought we discovered that was a config issue

petr-muller · 2025-02-04T23:28:02Z

pkg/plugins/label/label.go

+//	labels 		:= []string{"triage/unresolved", "area/testing"}
+//	needsLabels := []string{"triage"}
+//	result 		:= []string{"triage"}
+func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] {


Weak -1 from me, I'm a fan of private-unless-proven-to-be-necessary-public 😓

petr-muller · 2025-02-04T23:28:37Z

pkg/plugins/label/label.go

+// Example:
+//
+//	labels 		:= []string{"triage/unresolved", "area/testing"}
+//	needsLabels := []string{"triage"}


nit : weird indent

danilo-gemoli · 2025-02-05T09:53:22Z

Yes, this PR is supposed to handle #344. Thanks both for the reviews but I'll put this on hold and eventually close it if kubernetes/test-infra#34255 turns out to be enough.
/hold

petr-muller · 2025-03-18T22:59:23Z

/area plugins

k8s-triage-robot · 2025-06-16T23:52:20Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2025-07-16T23:55:43Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2025-08-16T00:39:51Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2025-08-16T00:39:57Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

feat: remove needs-* label when defining a category

aae1f05

k8s-ci-robot added the triage/unresolved Indicates an issue that can not or will not be resolved. label Feb 4, 2025

k8s-ci-robot requested review from MadhavJivrajani, Priyankasaggu11929, cjwagner and droslean February 4, 2025 11:49

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2025

jmguzik reviewed Feb 4, 2025

View reviewed changes

petr-muller reviewed Feb 4, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025

k8s-ci-robot added the area/plugins Issues or PRs related to prow's plugins for the hook component label Mar 18, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2025

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 16, 2025

k8s-ci-robot closed this Aug 16, 2025

-func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] {
+func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] {
+	needsLabelsSet := sets.New(needsLabels...)
+	categories := sets.New[string]()
+	for _, label := range labels {
+		if prefix, _, found := strings.Cut(label, "/"); found && needsLabelsSet.Has(prefix) {
+			categories.Insert(prefix)
+		}
+	}
+	return categories
+}

Remove a category label needs-* when the user is defining one #370

Remove a category label needs-* when the user is defining one #370

Uh oh!

Conversation

danilo-gemoli commented Feb 4, 2025

Uh oh!

k8s-ci-robot commented Feb 4, 2025

Uh oh!

netlify bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for k8s-prow ready!

Uh oh!

danilo-gemoli commented Feb 4, 2025

Uh oh!

jmguzik Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petr-muller Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jmguzik Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmguzik Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jmguzik commented Feb 4, 2025

Uh oh!

petr-muller commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petr-muller Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

petr-muller Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

danilo-gemoli commented Feb 5, 2025

Uh oh!

petr-muller commented Mar 18, 2025

Uh oh!

k8s-triage-robot commented Jun 16, 2025

Uh oh!

k8s-triage-robot commented Jul 16, 2025

Uh oh!

k8s-triage-robot commented Aug 16, 2025

Uh oh!

k8s-ci-robot commented Aug 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Remove a category label `needs-*` when the user is defining one #370

Remove a category label `needs-*` when the user is defining one #370

netlify bot commented Feb 4, 2025 •

edited

Loading

jmguzik Feb 4, 2025 •

edited

Loading

jmguzik Feb 4, 2025 •

edited

Loading

petr-muller commented Feb 4, 2025 •

edited

Loading