-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: remove needs-triage label when any triage label is added
#34255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove needs-triage label when any triage label is added
#34255
Conversation
|
Welcome @elizabeth-dev! |
|
Hi @elizabeth-dev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, elizabeth-dev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Labels: https://github.com/kubernetes/kubernetes/labels?q=triage%2F |
Thanks @elizabeth-dev @BenTheElder. Even I assumed that this was already the case. +1 (ContribEx) |
|
/hold cancel |
|
@elizabeth-dev: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Confirmed working as intended with Thank you! |
This change will make prow remove the label
needs-triagewhen anytriage/label is added to an issue or PR. This is done via modifying the regex used to decide when to remove such label so that it accepts anything with thetriage/prefix and not justtriage/acceptedFixes kubernetes-sigs/prow#344