Skip to content

User story tracking: repo setup #2

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
astoycos:user-stories
May 24, 2021
Merged

User story tracking: repo setup #2
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
astoycos:user-stories

Conversation

@astoycos
Copy link
Copy Markdown
Member

@astoycos astoycos commented May 14, 2021

This PR makes the template that user stories should follow and makes a new directory for user stories related to ClusterNetworkPolicy

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2021
@k8s-ci-robot k8s-ci-robot requested a review from rikatz May 14, 2021 19:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2021
@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 14, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2021
@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 14, 2021

/assign @rikatz @Dyanngg @srampal

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 14, 2021

@astoycos: GitHub didn't allow me to assign the following users: Dyanngg.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @rikatz @Dyanngg @srampal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 14, 2021

@Dyanngg This is what I was thinking for housing of any user stories for CNP let me know what you think

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2021
@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 20, 2021

Updated @Dyanngg

Dyanngg
Dyanngg approved these changes May 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @astoycos

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, Dyanngg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

srampal
srampal reviewed May 24, 2021
View reviewed changes
Copy link
Copy Markdown

@srampal srampal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

  1. Looks like there is a markdown formatting error in the very last section (References). The link does not work. It needs to be formatted as text. Please check and fix.
  2. This template should be more of a suggested guideline

Comment thread docs/userstories/README.md Outdated

### Resources:

* [Style-guides and template for a user story](agile-user-story.md)
Copy link
Copy Markdown

@srampal srampal May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown formatting error ? The link didnt work for me. Should be formatted as [text](url)

Copy link
Copy Markdown
Member Author

@astoycos astoycos May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Thanks!

@astoycos astoycos force-pushed the user-stories branch 2 times, most recently from 1c96d8a to b71223b Compare May 24, 2021 17:45
@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 24, 2021

Thanks for the catch! Fixed the error and added a line explaining that the template is just a "guideline"

srampal
srampal reviewed May 24, 2021
View reviewed changes
Copy link
Copy Markdown

@srampal srampal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that file package.json that has showed up in the diffs

@astoycos
Add place/methods to track new object user stories
7185696 
Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 24, 2021

Sorry about that @srampal It's done

@Dyanngg
Copy link
Copy Markdown
Contributor

Dyanngg commented May 24, 2021

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 24, 2021

@Dyanngg: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@srampal
Copy link
Copy Markdown

srampal commented May 24, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2021
@astoycos
Copy link
Copy Markdown
Member Author

astoycos commented May 24, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1535dfd into kubernetes-sigs:master May 24, 2021
@olivercodes olivercodes mentioned this pull request Nov 17, 2022
Closed
bowei added a commit to bowei/network-policy-api that referenced this pull request Nov 7, 2025
@bowei
Changes to implement option kubernetes-sigs#2 for the port matching
9c20cf0 
Example:

apiVersion: policy.networking.k8s.io/v1alpha2
kind: ClusterNetworkPolicy
metadata:
  name: cluster-wide-deny
spec:
  tier: Admin
  priority: 0
  subject:
    namespaces:
      matchLabels:
        kubernetes.io/metadata.name: sensitive-ns
  ingress:
    - action: Deny
      name: select-all-deny-all
      from:
      - pods:
          namespaceSelector:
            matchLabels: {}
          podSelector:
            matchLabels: {}
      match:
      - tcp:
        - port:
            number: 80
      - udp:
        - port:
            number: 50
      - tcp:
        - port:
            range:
              start: 1000
              end: 1050
      - namedPort: "www"
@bowei bowei mentioned this pull request Nov 7, 2025
Merged
bowei added a commit to bowei/network-policy-api that referenced this pull request Nov 24, 2025
@bowei
Changes to implement option kubernetes-sigs#2 for the port matching
1ac0440 
kubernetes-sigs#297

protocols:
  tcp:
    - destinationPort:
        number: 8080
    - destinationPort:
        range:
          start: 8080
          end: 9090
  udp:
    - destinationPort:
        number: 8080
    - destinationPort:
        number: 9090
  destinationNamedPort:
    - name: http
    - name: monitoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dyanngg Dyanngg Dyanngg approved these changes

@rikatz rikatz Awaiting requested review from rikatz

+1 more reviewer

@srampal srampal srampal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rikatz rikatz

@srampal srampal

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@astoycos @k8s-ci-robot @Dyanngg @srampal @rikatz