Skip to content

Update cyclonus makefile to figure out cpu arch#60

Closed
olivercodes wants to merge 1 commit into
kubernetes-sigs:masterfrom
olivercodes:feat/cyclonus-build
Closed

Update cyclonus makefile to figure out cpu arch#60
olivercodes wants to merge 1 commit into
kubernetes-sigs:masterfrom
olivercodes:feat/cyclonus-build

Conversation

@olivercodes
Copy link
Copy Markdown
Member

@mattfenwick @astoycos - I realize you might want to take a different approach with this (such as the tag), so no worries if you want to post back with other modifications we should add to cyclonus build/publish. I updated it whilst working on the ANP conformance tests setup (on my m1).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 15, 2022

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit c80da78
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6372ecd088d9500008f82177
😎 Deploy Preview https://deploy-preview-60--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olivercodes
Once this PR has been reviewed and has the lgtm label, please assign mattfenwick for approval by writing /assign @mattfenwick in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 15, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @olivercodes. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2022
@astoycos
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2022
@mattfenwick
Copy link
Copy Markdown
Contributor

mattfenwick commented Nov 16, 2022

hi @olivercodes thanks for putting this together !

( btw even though I'm listed as an approver ? , I shouldn't have final say on what does and doesn't go into this repo now that it's been upstreamed cc @astoycos , should somebody else get added to reviewers ? ) edit: nvm, looks like anybody in here can also approve

it's been a while and I'm not even sure if the makefile was used , check out https://github.com/kubernetes-sigs/network-policy-api/blob/master/cmd/cyclonus/.goreleaser.yml which I used for releases ... also please note that lots of things haven't been changed yet -- things that can't work in this repo -- like pushing images to my personal dockerhub account 😄

  • spin off issue: how should builds be handled long term , cc @astoycos

I don't 100% understand the goal of this change, if you wouldn't mind dropping a couple lines of motivation/goal it'll help me to understand what/why/how !

@olivercodes
Copy link
Copy Markdown
Member Author

olivercodes commented Nov 17, 2022

@mattfenwick:

Totally understandable. I was actually hoping to get more information like what you just posted! So this is a good start.

I had 2 goals with the change:

  1. get a short convo going around long-term support/maintenance for cyclonus itself. I was also thinking to update the Cyclonus build process (for long-term needs as you mentioned) whilst updating and working on the conformance tests for ANP, but didn't want to do anything there without some guidance on requirements in doing so.
  2. If it's useful, updating the makefile for the (probably very small number of) people that want do do local builds on a different architecture. But we could also remove it in preference of a basic readme build command like you have in the developer setup documentation.

@kundan2707
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2022
@olivercodes
Copy link
Copy Markdown
Member Author

Closing in favor of #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants