Update cyclonus makefile to figure out cpu arch#60
Conversation
✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olivercodes The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @olivercodes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
hi @olivercodes thanks for putting this together !
it's been a while and I'm not even sure if the makefile was used , check out https://github.com/kubernetes-sigs/network-policy-api/blob/master/cmd/cyclonus/.goreleaser.yml which I used for releases ... also please note that lots of things haven't been changed yet -- things that can't work in this repo -- like pushing images to my personal dockerhub account 😄
I don't 100% understand the goal of this change, if you wouldn't mind dropping a couple lines of motivation/goal it'll help me to understand what/why/how ! |
|
Totally understandable. I was actually hoping to get more information like what you just posted! So this is a good start. I had 2 goals with the change:
|
|
/lgtm |
|
Closing in favor of #62 |
@mattfenwick @astoycos - I realize you might want to take a different approach with this (such as the tag), so no worries if you want to post back with other modifications we should add to cyclonus build/publish. I updated it whilst working on the ANP conformance tests setup (on my m1).