-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template mixins #1359
Template mixins #1359
Conversation
Signed-off-by: Adrian Orive <[email protected]>
Hi @Adirio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Adrian Orive <[email protected]>
Signed-off-by: Adrian Orive <[email protected]>
903d6dd
to
0929f3d
Compare
Signed-off-by: Adrian Orive <[email protected]>
0929f3d
to
23c0628
Compare
Signed-off-by: Adrian Orive <[email protected]>
@DirectXMan12 This PR will help with the new file interface that was proposed by #1226 (which is quite outdated). Could you take a look? Despite saying that it has 43 modified files, most of the logic is in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR creates mixins for domain, repository, multi-group, boilerplate and resource as proposed in #1358, that inject those fields from the universe only on those templates that need it.
Motivation
This PR is scoped under #1218
Closes #1358