Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File interface #1227

Closed
wants to merge 9 commits into from
Closed

File interface #1227

wants to merge 9 commits into from

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 26, 2019 •
edited
Loading

Closes #1226

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Adirio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Adirio
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adirio Adirio mentioned this pull request Nov 26, 2019
Closed
@Adirio
Copy link
Contributor Author

Adirio commented Nov 26, 2019

The Travis shouldn't relate to this PR but as it is just a draft I won't pay much attention for now.

@Adirio Adirio force-pushed the scaffold-enhancement/interface branch from 63dd51b to 5b912e2 Compare November 26, 2019 13:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2019
@Adirio Adirio force-pushed the scaffold-enhancement/interface branch from 5b912e2 to c481070 Compare December 9, 2019 10:38
@Adirio Adirio force-pushed the scaffold-enhancement/interface branch from c481070 to 9210154 Compare December 16, 2019 11:00
@Adirio
Copy link
Contributor Author

Adirio commented Dec 16, 2019

Retriggering Travis

@Adirio Adirio closed this Dec 16, 2019
@Adirio Adirio reopened this Dec 16, 2019
@Adirio Adirio mentioned this pull request Dec 16, 2019
Closed
@DirectXMan12
Copy link
Contributor

@Adirio I kinda lost track of this. What's the status?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Jan 31, 2020

What's the status?

Waiting for #1340 before implementing this.

@Adirio Adirio force-pushed the scaffold-enhancement/interface branch from 9210154 to cd9103c Compare February 7, 2020 13:19
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2020
@Adirio Adirio marked this pull request as ready for review February 7, 2020 13:22
@Adirio Adirio changed the title [WIP] File interface File interface Feb 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Feb 7, 2020

Waiting on #1359
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2020
@Adirio Adirio force-pushed the scaffold-enhancement/interface branch from cd9103c to 18a0fbc Compare February 7, 2020 13:29
@Adirio Adirio mentioned this pull request Feb 20, 2020
Merged
@mengqiy mengqiy added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2020
@Adirio Adirio deleted the scaffold-enhancement/interface branch February 21, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Scaffold enhancement] File interface
4 participants
@Adirio @k8s-ci-robot @DirectXMan12 @mengqiy