Skip to content

capg: add options to set a service account or disable the default one#641

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
cpanato:update_capg
Jul 15, 2021
Merged

capg: add options to set a service account or disable the default one#641
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
cpanato:update_capg

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Jul 1, 2021

What this PR does / why we need it:
As part of the investigations why the nightly job is not working properly after we drop some GCP permissions, see kubernetes/k8s.io#2147

We are adding two more options in the GCE builder to allow to disable the default service account and another to use a specific service account.

In this PR we are using service_account_email to bound with the service account we setup for the gcp project.

/assign @spiffxp @ameukam @dims @codenrhoden

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
Add any other context for the reviewers

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 1, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 1, 2021
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jul 1, 2021

/test pull-azure-vhds

1 similar comment
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jul 1, 2021

/test pull-azure-vhds

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jul 12, 2021

/lgtm
/hold
I'll leave it to you to /unhold, I'm not sure if the pull-azure-vhds failure is something you care about

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 12, 2021
@codenrhoden
Copy link
Copy Markdown
Contributor

/lgtm
/hold cancel

The Azure issue right now is a flake. Some changes went into Prow yesterday that should make it not required for this PR, as it does not touch anything that would result in a change in Azure.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jul 14, 2021

@codenrhoden I will try to retest this, but if that fails again can we override the test? thanks!

/test pull-azure-vhds

@codenrhoden
Copy link
Copy Markdown
Contributor

@codenrhoden I will try to retest this, but if that fails again can we override the test? thanks!

@cpanato yeah, let's do it. I actually think it was one of your comments I saw one time that showed me the override command! I've never tried to use it. :)

/override pull-azure-vhds

@codenrhoden
Copy link
Copy Markdown
Contributor

Well, I guess that command doesn't work. The docs say you need to be a repo admin, and I am for this repo. :/

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jul 15, 2021

/retest

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jul 15, 2021

@codenrhoden maybe we can make this job not required?

@k8s-ci-robot k8s-ci-robot merged commit 2cedf67 into kubernetes-sigs:master Jul 15, 2021
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jul 15, 2021

works now :)

@cpanato cpanato deleted the update_capg branch July 15, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants