capg: add options to set a service account or disable the default one#641
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
|
/test pull-azure-vhds |
1 similar comment
|
/test pull-azure-vhds |
|
/lgtm |
|
/lgtm The Azure issue right now is a flake. Some changes went into Prow yesterday that should make it not required for this PR, as it does not touch anything that would result in a change in Azure. |
|
@codenrhoden I will try to retest this, but if that fails again can we override the test? thanks! /test pull-azure-vhds |
@cpanato yeah, let's do it. I actually think it was one of your comments I saw one time that showed me the /override pull-azure-vhds |
|
Well, I guess that command doesn't work. The docs say you need to be a repo admin, and I am for this repo. :/ |
|
/retest |
|
@codenrhoden maybe we can make this job not required? |
|
works now :) |
What this PR does / why we need it:
As part of the investigations why the nightly job is not working properly after we drop some GCP permissions, see kubernetes/k8s.io#2147
We are adding two more options in the GCE builder to allow to disable the default service account and another to use a specific service account.
In this PR we are using
service_account_emailto bound with the service account we setup for the gcp project./assign @spiffxp @ameukam @dims @codenrhoden
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
Add any other context for the reviewers