capg/nightly: remove check credentials#625
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jun 4, 2021
Merged
capg/nightly: remove check credentials#625k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
Member
|
/approve |
k8s-ci-robot
added
do-not-merge/hold
Member
Author
|
Steps I did to simulate the prow job using this PR change
It starts to run but then failed because
some snippet of the logs We need this PR to get in + a new role for the service account in k/k8s.io which I can add next here the screenshot of one image created
|
Member
Author
|
/test pull-azure-vhds |
Member
Author
|
updated screenshot both three images
|
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
Contributor
|
/retest |
Member
Author
|
all green now @codenrhoden /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codenrhoden, cpanato, dims The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
@cpanato Images are successfully built: gcloud compute images list --filter=\"family=capi-ubuntu-1804-k8s-\" --filter="name~^cluster-api" --format="value(name)" --project=k8s-staging-cluster-api-gcp
cluster-api-ubuntu-1804-v1-18-18-nightly
cluster-api-ubuntu-1804-v1-19-10-nightly
cluster-api-ubuntu-1804-v1-20-6-nightly |
Member
Contributor
|
I have a security concern with the way the k8s-infra role was assigned, ref: kubernetes/k8s.io#2124 (comment) Which specific service account needs to be used? We should be binding the role against that. Not the whole project |
Member
Author
|
lets address the issues in this discussion here: kubernetes/k8s.io#2124 (comment) and get that fixed. there are other things I would like to do after this, like make the images public, so we can use in the CAPG jobs and avoid to recreate that everytime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Trying to setup the job to run the image builds for CAPG.
The nightly job: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/wg-k8s-infra/trusted/image-builder/image-builder-periodics.yaml uses a service account so in theory, we don't need to expected the
GOOGLE_APPLICATION_CREDENTIALSwill be injected.Per this document: https://github.com/kubernetes/test-infra/tree/master/workload-identity#pods we can just use it
but not sure if require more changes here or in the job definition. This is a debug PR to check.
I will try to set up something similar using my personal account and see if I can simulate a similar thing.
/assign @dims @ameukam @codenrhoden @spiffxp
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
Add any other context for the reviewers