Skip to content

locked ansible base version#624

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
perithompson:lock-ansible-base
Jun 3, 2021
Merged

locked ansible base version#624
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
perithompson:lock-ansible-base

Conversation

@perithompson
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
An issue has been identified in ansible-base 2.10.10 that causes win_templates to fail to copy to a windows host. As there is currently no way to lock the ansible base version I have added a downgrade to lock this until we are happy that the issue has been resolved in ansible

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2021
@perithompson
Copy link
Copy Markdown
Contributor Author

@jsturtevant @codenrhoden got there eventually, the problem with the templates was the version of ansible base

@codenrhoden
Copy link
Copy Markdown
Contributor

Thanks for tracking that down, @perithompson. I get why you are setting this explicitly in your other PR now...
This seems like a temporary workaround until we can set a new Ansible version (> 2.10.10) that has this problem fixed.
/assign @jsturtevant
^ PTAL
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@jayunit100
Copy link
Copy Markdown
Contributor

/lgtm

@jsturtevant
Copy link
Copy Markdown
Contributor

/lgtm
/approve

Thanks for tracking this down @perithompson!

@codenrhoden
Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, jsturtevant, perithompson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0b88a0c into kubernetes-sigs:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants