Fix validation markers release 1.4#4177
Closed
KillianGolds wants to merge 36 commits intokubernetes-sigs:mainfrom
Closed
Fix validation markers release 1.4#4177KillianGolds wants to merge 36 commits intokubernetes-sigs:mainfrom
KillianGolds wants to merge 36 commits intokubernetes-sigs:mainfrom
Conversation
* Improve some ListenetSet gep descriptions * Add examples of conflicting ListenerSets * Fix some review findings * Fix some comments on GEP * Make the behavior on route attachement explicit * Fix some reviews * Use XListenerSet on example kinds * Final fix on listenerset gep * Fix some more reviews * Add clarification on ListenerSet attachment
* Switch to registry.k8s.io/coredns/coredns, only pull if not present * Properly support multiple embedded manifests
Copy: apis/v1alpha3/backendtlspolicy_types.go -> apis/v1/backendtlspolicy_types.go apis/v1alpha2/policy_types.go -> apis/v1/policy_types.go Update: apis/v1alpha2/policy_types.go apis/v1alpha3/backendtlspolicy_types.go config/crd/kustomization.yaml conformance/tests/backendtlspolicy-conflict-resolution.go conformance/tests/backendtlspolicy-conflict-resolution.yaml conformance/tests/backendtlspolicy-invalid-ca-certificate-ref.go conformance/tests/backendtlspolicy-invalid-ca-certificate-ref.yaml conformance/tests/backendtlspolicy-invalid-kind.go conformance/tests/backendtlspolicy-invalid-kind.yaml conformance/tests/backendtlspolicy-observed-generation-bump.go conformance/tests/backendtlspolicy-observed-generation-bump.yaml conformance/tests/backendtlspolicy-san.go conformance/tests/backendtlspolicy-san.yaml conformance/tests/backendtlspolicy.go conformance/tests/backendtlspolicy.yaml conformance/utils/kubernetes/helpers.go examples/standard/backendtlspolicy/backendtlspolicy-ca-certs.yaml examples/standard/backendtlspolicy/backendtlspolicy-system-certs.yaml pkg/features/backendtlspolicy.go pkg/generator/main.go pkg/test/cel/backendtlspolicy_test.go site-src/guides/tls.md Delete: examples/experimental/v1alpha3/backendtlspolicy-ca-certs.yaml examples/experimental/v1alpha3/backendtlspolicy-system-certs.yaml Regenerate the remaining files: rm -rf pkg/client make generate hack/../hack/verify-golint.sh (if needed)
…rform cleanup (kubernetes-sigs#4094) Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
Removed mlavacca from gateway-api-maintainers and added to gateway-api-mesh-leads.
* Fix GEP API and geps metadata The GEP API is using a wrong structure/tag name for some fields, so this PR fixes the markers. Additionally the metadata.yaml files from some GEPs are fixed to reflect the right GEP API structure * Implement automatic NAV generation This change makes the navigation section of GW API website to be generated. The modification adds a new Go program that is able to transverse the GEP directory and generate a navigation section correctly from the existing GEPs. Additionally, some scripts and Makefiles are added to verify if the generated nav.yml file reflects the current state of GEPs, a Github Action that fails in case nav.yml is outdated * Add the new generated nav file
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
Bumps the k8s-io group with 5 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.34.0` | `0.34.1` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.34.0` | `0.34.1` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.34.0` | `0.34.1` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.34.0` | `0.34.1` | | [k8s.io/code-generator](https://github.com/kubernetes/code-generator) | `0.34.0` | `0.34.1` | Updates `k8s.io/api` from 0.34.0 to 0.34.1 - [Commits](kubernetes/api@v0.34.0...v0.34.1) Updates `k8s.io/apiextensions-apiserver` from 0.34.0 to 0.34.1 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.34.0...v0.34.1) Updates `k8s.io/apimachinery` from 0.34.0 to 0.34.1 - [Commits](kubernetes/apimachinery@v0.34.0...v0.34.1) Updates `k8s.io/client-go` from 0.34.0 to 0.34.1 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.34.0...v0.34.1) Updates `k8s.io/code-generator` from 0.34.0 to 0.34.1 - [Commits](kubernetes/code-generator@v0.34.0...v0.34.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.34.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.34.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-version: 0.34.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-version: 0.34.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/code-generator dependency-version: 0.34.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kubernetes-sigs#4086) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.21.0 to 0.22.1. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.21.0...v0.22.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-version: 0.22.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update GEP template with some clarifying sections * Apply suggestions on GEP template update Co-authored-by: Nick Young <inocuo@gmail.com> --------- Co-authored-by: Nick Young <inocuo@gmail.com>
… in GWC Status. (kubernetes-sigs#4116) * Removing experimental annotation from supportedFeatures in GWC Status. * Run make generate to update generated files --------- Co-authored-by: Beka Modebadze <bexx@google.com>
…portedFeatures (kubernetes-sigs#4118) * fix: use inferred supported features to set extendedSupportedFeatures Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * extend unit tests with assertion for extendedSupportedFeatures Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> * refactor NewConformanceTestSuite Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> --------- Signed-off-by: Norwin Schnyder <norwin.schnyder+github@gmail.com> Co-authored-by: Norwin Schnyder <norwin.schnyder+github@gmail.com>
…est (kubernetes-sigs#4117) * conformance: fix invalid BackendTLSPolicy conformance test * Move to a real one --------- Co-authored-by: John Howard <john.howard@solo.io>
…atically inferring supported features from Mesh.Status (kubernetes-sigs#4124) * Read SupportedFeatures from XMesh status for conformance test. * Defined Mesh flag for testing. * Renamed mesh flag. * renamed fetched mesh features set. * suite_test formatting. * Set mesh flag empty default value --------- Co-authored-by: Beka Modebadze <bexx@google.com>
…netes-sigs#4125) Bumps [mkdocs-mermaid2-plugin](https://github.com/fralau/mkdocs-mermaid2-plugin) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/fralau/mkdocs-mermaid2-plugin/releases) - [Changelog](https://github.com/fralau/mkdocs-mermaid2-plugin/blob/master/CHANGELOG.md) - [Commits](fralau/mkdocs-mermaid2-plugin@v1.2.1...v1.2.2) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…netes-sigs#4127) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.75.0 to 1.75.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.75.0...v1.75.1) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…igs#4128) Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.6.18 to 9.6.20. - [Release notes](https://github.com/squidfunk/mkdocs-material/releases) - [Changelog](https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG) - [Commits](squidfunk/mkdocs-material@9.6.18...9.6.20) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…netes-sigs#4126) Updates the requirements on [markdown](https://github.com/Python-Markdown/markdown) to permit the latest version. - [Release notes](https://github.com/Python-Markdown/markdown/releases) - [Changelog](https://github.com/Python-Markdown/markdown/blob/master/docs/changelog.md) - [Commits](Python-Markdown/markdown@3.8...3.9.0) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ubernetes-sigs#4129) Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/main/envtest-releases.yaml) - [Commits](kubernetes-sigs/controller-tools@v0.18.0...v0.19.0) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: bump to v1.4.0-rc.2 Signed-off-by: Shane Utt <shaneutt@linux.com> * docs: add the v1.4.0-rc.2 CHANGELOG entry Signed-off-by: Shane Utt <shaneutt@linux.com> --------- Signed-off-by: Shane Utt <shaneutt@linux.com>
otherwise we send requests to `http://[fc00/backendtlspolicy-nonexistent-ca-certificate-ref"` which is very wrong Co-authored-by: John Howard <john.howard@solo.io>
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
Signed-off-by: Shane Utt <shaneutt@linux.com>
This commit corrects several invalid Kubebuilder validation markers that caused controller-gen validation errors. Changes: Removed +listType=atomic from non-array fields: gateway_types.go: Namespaces *RouteNamespaces (line 806) backendtlspolicy_types.go: WellKnownCACertificates (line 192) Replaced MaxLength with MaxItems for array fields: httproute_types.go: AllowedRequestHeaders []string (lines 1674, 1722) httproute_types.go: AllowedResponseHeaders []string (line 1733) Removed Minimum/Maximum from non-primitive fields: xlistenerset_types.go: Port PortNumber (lines 170, 255) Added CRD marker validation to hack/update-clientset.sh to detect invalid markers during development and CI. These fixes ensure validation markers are applied only to compatible field types. Signed-off-by: Killian Golds <kgolds@redhat.com>
Addresses reviewers feedback by moving validation to the type level. Creates StatusPortNumber for status fields requiring valid ports (1-65535). Signed-off-by: Killian Golds <kgolds@redhat.com>
Contributor
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
Contributor
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
k8s-ci-robot
added
needs-ok-to-test
Contributor
|
Hi @KillianGolds. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KillianGolds The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: