Skip to content

Update GEP template with some clarifying sections#4073

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
rikatz:conformance-on-meta
Sep 19, 2025
Merged

Update GEP template with some clarifying sections#4073
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
rikatz:conformance-on-meta

Conversation

@rikatz
Copy link
Copy Markdown
Member

@rikatz rikatz commented Sep 8, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Proposal to update the GEP template with some missing sections that exists on other GEPs

Which issue(s) this PR fixes:
Part of #4026

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Sep 8, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2025
Copy link
Copy Markdown
Contributor

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @rikatz, I made some language suggestions for clarity, but this is okay without them.

/approve

Comment thread geps/gep-696/index.md Outdated
Comment thread geps/gep-696/index.md Outdated
Comment thread geps/gep-696/index.md Outdated
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
Co-authored-by: Nick Young <inocuo@gmail.com>
@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented Sep 17, 2025

@youngnick accepted directly your commits :) Thanks for the review!

@candita
Copy link
Copy Markdown
Contributor

candita commented Sep 18, 2025

Good additions. TIL that we have a template!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@robscott
Copy link
Copy Markdown
Member

Thanks @rikatz!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6b6e608 into kubernetes-sigs:main Sep 19, 2025
19 checks passed
shaneutt pushed a commit that referenced this pull request Sep 19, 2025
* Update GEP template with some clarifying sections

* Apply suggestions on GEP template update

Co-authored-by: Nick Young <inocuo@gmail.com>

---------

Co-authored-by: Nick Young <inocuo@gmail.com>
tylerauerbeck pushed a commit to tylerauerbeck/gateway-api that referenced this pull request Nov 27, 2025
* Update GEP template with some clarifying sections

* Apply suggestions on GEP template update

Co-authored-by: Nick Young <inocuo@gmail.com>

---------

Co-authored-by: Nick Young <inocuo@gmail.com>
RoseWrightdev pushed a commit to RoseWrightdev/gateway-api that referenced this pull request Jan 8, 2026
* Update GEP template with some clarifying sections

* Apply suggestions on GEP template update

Co-authored-by: Nick Young <inocuo@gmail.com>

---------

Co-authored-by: Nick Young <inocuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants