-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move mesh test app into k8s org #1895
Comments
/assign @kflynn @keithmattix |
/assign @t-eckert |
@keithmattix: GitHub didn't allow me to assign the following users: t-eckert. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The code for the app server is here: https://github.com/istio/istio/tree/master/pkg/test/echo. A good first step would be to just move this code into a repo under kubernetes-sigs. |
/reopen |
@keithmattix: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@keithmattix I actually did intend to close this one as I was taking the text of the issue very literally:
So at least from my perspective, the goal was to build an image from within Gateway API and push it to a k8s owned registry. We have accomplished both of those things, despite not actually moving the code into this repo. In my opinion duplicating the code here is not really helpful, the main goal was to ensure that we control the image and can publish updates/version however it works best for us. I know the actual title of the issue seems to suggest some more broader action, but I don't think it's required, so will close this out. If we want to consider moving code over here maybe we should discuss that in a separate issue. /close |
Ah I misunderstood the previous discussion then; thanks for the clarification! |
Originally posted by @robscott in #1878 (comment)
The text was updated successfully, but these errors were encountered: