Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mesh test app into k8s org #1895

Closed
howardjohn opened this issue Mar 31, 2023 · 8 comments · Fixed by #1999
Closed

Move mesh test app into k8s org #1895

howardjohn opened this issue Mar 31, 2023 · 8 comments · Fixed by #1999
Assignees
Labels
area/mesh Mesh networks related

Comments

@howardjohn
Copy link
Contributor

          I'd rather have this image owned by k8s/gateway-api infra so we can bundle versions of it with each release of our conformance tests. Can you create an issue to track following up on that? Shorter term can we at least use a pinned version of this image so a change in this image doesn't have an immediate impact on our conformance tests?

Originally posted by @robscott in #1878 (comment)

@keithmattix
Copy link
Contributor

/assign @kflynn @keithmattix

@keithmattix
Copy link
Contributor

/assign @t-eckert

@k8s-ci-robot
Copy link
Contributor

@keithmattix: GitHub didn't allow me to assign the following users: t-eckert.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @t-eckert

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@keithmattix
Copy link
Contributor

keithmattix commented Apr 25, 2023

The code for the app server is here: https://github.com/istio/istio/tree/master/pkg/test/echo. A good first step would be to just move this code into a repo under kubernetes-sigs.

@keithmattix
Copy link
Contributor

/reopen
The above PRs don't actual change the ownership of the code or build the image

@k8s-ci-robot
Copy link
Contributor

@keithmattix: Reopened this issue.

In response to this:

/reopen
The above PRs don't actual change the ownership of the code or build the image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this May 9, 2023
@robscott
Copy link
Member

robscott commented May 9, 2023

@keithmattix I actually did intend to close this one as I was taking the text of the issue very literally:

I'd rather have this image owned by k8s/gateway-api infra so we can bundle versions of it with each release of our conformance tests. Can you create an issue to track following up on that? Shorter term can we at least use a pinned version of this image so a change in this image doesn't have an immediate impact on our conformance tests?

So at least from my perspective, the goal was to build an image from within Gateway API and push it to a k8s owned registry. We have accomplished both of those things, despite not actually moving the code into this repo. In my opinion duplicating the code here is not really helpful, the main goal was to ensure that we control the image and can publish updates/version however it works best for us.

I know the actual title of the issue seems to suggest some more broader action, but I don't think it's required, so will close this out. If we want to consider moving code over here maybe we should discuss that in a separate issue.

/close

@robscott robscott closed this as completed May 9, 2023
@keithmattix
Copy link
Contributor

Ah I misunderstood the previous discussion then; thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mesh Mesh networks related
Projects
Development

Successfully merging a pull request may close this issue.

6 participants