Skip to content

Conversation

@googs1025
Copy link
Member

@googs1025 googs1025 commented Dec 1, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1915

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 1, 2025
@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit aa6d586
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/692cf4ecd4fd1a0008a6fce8
😎 Deploy Preview https://deploy-preview-1916--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2025
@googs1025
Copy link
Member Author

local test

➜  llm-instance-gateway git:(fix/script) MAJOR=1 MINOR=3 PATCH=0 RC=1 ./hack/release-quickstart.sh

Using release tag: v1.3.0-rc.1
Using vLLM GPU image version: 0.10.0
Using vLLM CPU image version: 0.10.0
Using vLLM Simulator image version: 0.3.2-fix
Updating version/version.go ...
Generating CRDs with new annotations in config/crd/
2025/12/01 09:42:30 generating CRD for InferenceModelRewrite.inference.networking.x-k8s.io
2025/12/01 09:42:30 generating CRD for InferenceObjective.inference.networking.x-k8s.io
2025/12/01 09:42:30 generating CRD for InferencePool.inference.networking.k8s.io
2025/12/01 09:42:30 generating CRD for InferencePool.inference.networking.x-k8s.io
2025/12/01 09:42:30 generating CRD for InferencePoolImport.inference.networking.x-k8s.io
Generated CRDs with new annotations in config/crd/
Updating pkg/README.md ...
Updating config/charts/inferencepool/values.yaml, config/charts/body-based-routing/values.yaml, and conformance/resources/base.yaml ...
Updating config/manifests/vllm/gpu-deployment.yaml ...
Updating config/manifests/vllm/cpu-deployment.yaml ...
Updating config/manifests/vllm/sim-deployment.yaml ...
Staging version/version.go config/crd/ pkg/README.md config/charts/inferencepool/values.yaml config/charts/body-based-routing/values.yaml conformance/resources/base.yaml config/manifests/vllm/gpu-deployment.yaml config/manifests/vllm/cpu-deployment.yaml config/manifests/vllm/sim-deployment.yaml site-src/guides/index.md files...
Cleaning up temporary backup files...
Release quickstart update complete.
➜  llm-instance-gateway git:(fix/script) ✗ grep -r "v1.3.0-rc.1" \                                                                                   
  version/version.go \
  config/charts/inferencepool/values.yaml \
  conformance/resources/base.yaml \
  config/manifests/vllm/gpu-deployment.yaml \
  config/manifests/vllm/cpu-deployment.yaml \
  site-src/guides/index.md
version/version.go:     BundleVersion = "v1.3.0-rc.1"
config/charts/inferencepool/values.yaml:    tag: v1.3.0-rc.1
config/charts/inferencepool/values.yaml:        tag: v1.3.0-rc.1
config/charts/inferencepool/values.yaml:        tag: v1.3.0-rc.1
conformance/resources/base.yaml:        image: registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0-rc.1
conformance/resources/base.yaml:        image: registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0-rc.1
conformance/resources/base.yaml:        image: registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0-rc.1
config/manifests/vllm/gpu-deployment.yaml:          image: registry.k8s.io/gateway-api-inference-extension/lora-syncer:v1.3.0-rc.1
config/manifests/vllm/cpu-deployment.yaml:          image: registry.k8s.io/gateway-api-inference-extension/lora-syncer:v1.3.0-rc.1
site-src/guides/index.md:    kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/vllm/gpu-deployment.yaml
site-src/guides/index.md:    kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/vllm/cpu-deployment.yaml
site-src/guides/index.md:    kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/vllm/sim-deployment.yaml
site-src/guides/index.md:kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/v1.3.0-rc.1/manifests.yaml
site-src/guides/index.md:   export IGW_CHART_VERSION=v1.3.0-rc.1
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/gke/gateway.yaml
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/gke/httproute.yaml
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/agentgateway/gateway.yaml
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/agentgateway/httproute.yaml
site-src/guides/index.md:   kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/inferenceobjective.yaml
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/inferenceobjective.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/vllm/cpu-deployment.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/vllm/gpu-deployment.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/vllm/sim-deployment.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/v1.3.0-rc.1/manifests.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/gke/gateway.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/gke/healthcheck.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/gke/gcp-backend-policy.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/gke/httproute.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/istio/gateway.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/istio/httproute.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/agentgateway/gateway.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0-rc.1/config/manifests/gateway/agentgateway/httproute.yaml --ignore-not-found
➜  llm-instance-gateway git:(fix/script) ✗ 
➜  llm-instance-gateway git:(fix/script) ✗ 
➜  llm-instance-gateway git:(fix/script) ✗ MAJOR=1 MINOR=3 PATCH=0  ./hack/release-quickstart.sh 
  
Using release tag: v1.3.0
Using vLLM GPU image version: 0.10.0
Using vLLM CPU image version: 0.10.0
Using vLLM Simulator image version: 0.3.2-fix
Updating version/version.go ...
Generating CRDs with new annotations in config/crd/
2025/12/01 09:46:50 generating CRD for InferenceModelRewrite.inference.networking.x-k8s.io
2025/12/01 09:46:50 generating CRD for InferenceObjective.inference.networking.x-k8s.io
2025/12/01 09:46:50 generating CRD for InferencePool.inference.networking.k8s.io
2025/12/01 09:46:50 generating CRD for InferencePool.inference.networking.x-k8s.io
2025/12/01 09:46:50 generating CRD for InferencePoolImport.inference.networking.x-k8s.io
Generated CRDs with new annotations in config/crd/
Updating pkg/README.md ...
Updating config/charts/inferencepool/values.yaml, config/charts/body-based-routing/values.yaml, and conformance/resources/base.yaml ...
Updating config/manifests/vllm/gpu-deployment.yaml ...
Updating config/manifests/vllm/cpu-deployment.yaml ...
Updating config/manifests/vllm/sim-deployment.yaml ...
Staging version/version.go config/crd/ pkg/README.md config/charts/inferencepool/values.yaml config/charts/body-based-routing/values.yaml conformance/resources/base.yaml config/manifests/vllm/gpu-deployment.yaml config/manifests/vllm/cpu-deployment.yaml config/manifests/vllm/sim-deployment.yaml site-src/guides/index.md files...
Cleaning up temporary backup files...
Release quickstart update complete.
➜  llm-instance-gateway git:(fix/script) ✗ grep -r "v1.3.0" \                                   
  version/version.go \
  config/charts/inferencepool/values.yaml \
  conformance/resources/base.yaml \
  config/manifests/vllm/gpu-deployment.yaml \
  config/manifests/vllm/cpu-deployment.yaml \
  site-src/guides/index.md
version/version.go:     BundleVersion = "v1.3.0"
config/charts/inferencepool/values.yaml:    tag: v1.3.0
config/charts/inferencepool/values.yaml:        tag: v1.3.0
config/charts/inferencepool/values.yaml:        tag: v1.3.0
conformance/resources/base.yaml:        image: gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
conformance/resources/base.yaml:        image: gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
conformance/resources/base.yaml:        image: registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0
conformance/resources/base.yaml:        image: registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0
conformance/resources/base.yaml:        image: gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
conformance/resources/base.yaml:        image: gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
conformance/resources/base.yaml:        image: gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
conformance/resources/base.yaml:        image: registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0
config/manifests/vllm/gpu-deployment.yaml:          image: registry.k8s.io/gateway-api-inference-extension/lora-syncer:v1.3.0
config/manifests/vllm/cpu-deployment.yaml:          image: registry.k8s.io/gateway-api-inference-extension/lora-syncer:v1.3.0
site-src/guides/index.md:    kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/vllm/gpu-deployment.yaml
site-src/guides/index.md:    kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/vllm/cpu-deployment.yaml
site-src/guides/index.md:    kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/vllm/sim-deployment.yaml
site-src/guides/index.md:kubectl apply -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/v1.3.0/manifests.yaml
site-src/guides/index.md:   export IGW_CHART_VERSION=v1.3.0
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/gke/gateway.yaml
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/gke/httproute.yaml
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/agentgateway/gateway.yaml
site-src/guides/index.md:         kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/agentgateway/httproute.yaml
site-src/guides/index.md:   kubectl apply -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/inferenceobjective.yaml
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/inferenceobjective.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/vllm/cpu-deployment.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/vllm/gpu-deployment.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/vllm/sim-deployment.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases/download/v1.3.0/manifests.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/gke/gateway.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/gke/healthcheck.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/gke/gcp-backend-policy.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/gke/httproute.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/istio/gateway.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/istio/httproute.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/agentgateway/gateway.yaml --ignore-not-found
site-src/guides/index.md:      kubectl delete -f https://raw.githubusercontent.com/kubernetes-sigs/gateway-api-inference-extension/refs/tags/v1.3.0/config/manifests/gateway/agentgateway/httproute.yaml --ignore-not-found
➜  llm-instance-gateway git:(fix/script) ✗ grep -r "v1.3.0-rc.1" \                                  
  version/version.go \
  config/charts/inferencepool/values.yaml \
  conformance/resources/base.yaml \
  config/manifests/vllm/gpu-deployment.yaml \
  config/manifests/vllm/cpu-deployment.yaml \
  site-src/guides/index.md
➜  llm-instance-gateway git:(fix/script) ✗ yq '.spec.template.spec.containers[].image' conformance/resources/base.yaml
gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
---
gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
---
registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0
---
registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0
---
gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
gcr.io/k8s-staging-gateway-api/echo-basic:v20251106-v1.3.0-263-g47c3435c
---
registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0

@googs1025
Copy link
Member Author

cc @nirrozenbaum

@googs1025
Copy link
Member Author

Verification Steps

  1. Created an RC release (v1.3.0-rc.1)
    Ran:

    MAJOR=1 MINOR=3 PATCH=0 RC=1 ./hack/release-quickstart.sh

    Confirmed that all relevant files (e.g., conformance/resources/base.yaml, gpu-deployment.yaml, etc.) were correctly updated to use registry.k8s.io/.../epp:v1.3.0-rc.1 and .../lora-syncer:v1.3.0-rc.1.

  2. Promoted to final release (v1.3.0)
    Ran:

    MAJOR=1 MINOR=3 PATCH=0 ./hack/release-quickstart.sh

    Verified that:

    • All v1.3.0-rc.1 tags were fully replaced with v1.3.0.
    • No trace of rc.1 remains in any file (confirmed via grep -r "v1.3.0-rc.1" → no output).
    • Both epp and lora-syncer images now correctly use :v1.3.0 with the official registry (registry.k8s.io).
  3. Validated image integrity
    Used yq to inspect containers in conformance/resources/base.yaml and confirmed:

    registry.k8s.io/gateway-api-inference-extension/epp:v1.3.0

@googs1025
Copy link
Member Author

/test pull-gateway-api-inference-extension-test-unit-main

@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: googs1025, nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit ea4a56f into kubernetes-sigs:main Dec 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Release Automation] lora-syncer and conformance base file are not updated correctly when updating from RC to final release

3 participants