generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 206
Closed
Labels
gie-area/releaseCategorizes an issue or PR as relevant to GIE releases.Categorizes an issue or PR as relevant to GIE releases.good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.
Description
What happened:
while cutting final release v1.2.0 (after RC1), the release script automation did not update few places with the right version.
more specifically - the release script missed the updates in conformance/resources/base.yaml and in the gpu/cpu yaml deployment file it didn't update the lora syncer correct image.
concrete example can be found here (I updated those manually):
52ed3ab
What you expected to happen:
release script should update correctly all places.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
- Kubernetes version (use
kubectl version): - Inference extension version (use
git describe --tags --dirty --always): - Cloud provider or hardware configuration:
- Install tools:
- Others:
Metadata
Metadata
Assignees
Labels
gie-area/releaseCategorizes an issue or PR as relevant to GIE releases.Categorizes an issue or PR as relevant to GIE releases.good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.