Skip to content

[metrics]: Allow EPP to register metrics from extension #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Oct 29, 2025
Merged

[metrics]: Allow EPP to register metrics from extension #1787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cmd/epp/runner/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ func NewRunner() *Runner {
type Runner struct {
requestControlConfig *requestcontrol.Config
schedulerConfig *scheduling.SchedulerConfig
customCollectors []prometheus.Collector
}

func (r *Runner) WithRequestControlConfig(requestControlConfig *requestcontrol.Config) *Runner {
Expand All @@ -155,6 +156,11 @@ func (r *Runner) WithSchedulerConfig(schedulerConfig *scheduling.SchedulerConfig
return r
}

func (r *Runner) WithCustomCollectors(collectors ...prometheus.Collector) *Runner {
r.customCollectors = collectors
return r
}

func (r *Runner) Run(ctx context.Context) error {
opts := zap.Options{
Development: true,
Expand Down Expand Up @@ -205,6 +211,9 @@ func (r *Runner) Run(ctx context.Context) error {

// --- Setup Metrics Server ---
customCollectors := []prometheus.Collector{collectors.NewInferencePoolMetricsCollector(datastore)}
if r.customCollectors != nil {
customCollectors = append(customCollectors, r.customCollectors...)
}
metrics.Register(customCollectors...)
metrics.RecordInferenceExtensionInfo(version.CommitSHA, version.BuildRef)
// Register metrics handler.
Expand Down