[metrics]: Allow EPP to register metrics from extension #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation is llm-d/llm-d-inference-scheduler#386 that we would like to have more metrics from llm-d inference scheduler plugin. The current metrics implementation is bundled in the runner of EPP, so this PR extends the runner to allow extention to register prometheus metrics collector. See llm-d/llm-d-inference-scheduler#405 for a draft PR of how metrics are going to be implemented in the plugin. I have tested locally that both EPP and inference scheduler metrics can be exported through the pod /metrics endpoint.
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
Contributor
Author
Collaborator
|
/lgtm |
k8s-ci-robot
added
lgtm
Contributor
|
/lgtm Thanks Jeff! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeffLuoo, kfswain, nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
I want to make it to llm-d 0.4 release. @kfswain Hi Kellen, are you going to cut a branch for llm-d 0.4 or it will use 1.1.0? If 1.1.0 will be used, I would like this PR to be cherry-picked. Thanks! |
JeffLuoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is
llm-d/llm-d-inference-scheduler#386 that we would like to have more metrics from llm-d inference scheduler plugin.
The current metrics implementation is bundled in the runner of EPP, so this PR extends the runner to allow extension to register prometheus metrics collector.
See llm-d/llm-d-inference-scheduler#405 for a draft PR of how metrics are going to be implemented in the plugin.
I have tested locally that both EPP and inference scheduler metrics can be exported through the pod /metrics endpoint.
What type of PR is this?
What this PR does / why we need it:
llm-d/llm-d-inference-scheduler#386
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: