fix(rbac): conditional endpointslices perms by vflaux · Pull Request #5746 · kubernetes-sigs/external-dns

vflaux · 2025-08-18T15:27:38Z

What does it do ?

Only grant endpointslices RBAC when service source is used in chart.
Removes unneeded v1/endpoints permissions in godaddy & ovh tutorials.

Motivation

We grant endpointslices permissions when not needed in the helm chart. If I'm not mistaken, only the service source use endpointslices.

More

Yes, this PR title follows Conventional Commits
Yes, I added unit tests
Yes, I updated end user documentation accordingly

k8s-ci-robot · 2025-08-18T15:27:49Z

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ivankatliarchuk · 2025-08-19T07:27:53Z

can we add helm unit tests as well?

/ok-to-test

stevehipwell

Thanks for the PR @vflaux, could you please add an entry to the chart CHANGELOG?

charts/external-dns/CHANGELOG.md

…ted endpoints Only grant endpointslices permissions when using service source and remove outdated endpoints RBAC from provider tutorials. Add rbac tests for the chart.

stevehipwell · 2025-08-19T11:26:17Z

/lgtm

ivankatliarchuk · 2025-08-19T11:32:46Z

/approve

k8s-ci-robot · 2025-08-19T11:32:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ivankatliarchuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ted endpoints (kubernetes-sigs#5746) Only grant endpointslices permissions when using service source and remove outdated endpoints RBAC from provider tutorials. Add rbac tests for the chart.

…o v0.19.0 (#805) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [registry.k8s.io/external-dns/external-dns](https://github.com/kubernetes-sigs/external-dns) | minor | `v0.18.0` -> `v0.19.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/external-dns (registry.k8s.io/external-dns/external-dns)</summary> ### [`v0.19.0`](https://github.com/kubernetes-sigs/external-dns/releases/tag/v0.19.0) [Compare Source](kubernetes-sigs/external-dns@v0.18.0...v0.19.0) #### General information - :information\_source: CLI flags allows to set behavior of previous version on the two breaking changes included in this release, if needed. - :information\_source: Thanks to [@valerian-roche](https://github.com/valerian-roche), this version can reduce the *average* memory usage by \~10 times, see [#5596](kubernetes-sigs/external-dns#5596) #### ⚠️ Breaking Changes - feat(nodes)!: expose external ipv6 by default by [@mloiseleur](https://github.com/mloiseleur) in [#5575](kubernetes-sigs/external-dns#5575) - feat(traefik)!: disable legacy listeners on traefik.containo.us API Group by [@mloiseleur](https://github.com/mloiseleur) in [#5565](kubernetes-sigs/external-dns#5565) #### 🚀 Features - feat(aws): add support for ap-east-2 by [@chemi0213](https://github.com/chemi0213) in [#5638](kubernetes-sigs/external-dns#5638) - feat(aws): add support for geoproximity routing by [@prasadkatti](https://github.com/prasadkatti) in [#5347](kubernetes-sigs/external-dns#5347) - feat(azure): update Azure provider configuration and documentation by [@antchand](https://github.com/antchand) in [#5648](kubernetes-sigs/external-dns#5648) - feat(chart): add option to configure annotationFilter via dedicated helm value by [@dshatokhin](https://github.com/dshatokhin) in [#5737](kubernetes-sigs/external-dns#5737) - feat(events): raise k8s events with fake provider by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5659](kubernetes-sigs/external-dns#5659) - feat(metrics): publish build\_info metric by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5643](kubernetes-sigs/external-dns#5643) - feat(nodes)!: expose external ipv6 by default by [@mloiseleur](https://github.com/mloiseleur) in [#5575](kubernetes-sigs/external-dns#5575) - feat(source/istio): support version 1.25+ by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5611](kubernetes-sigs/external-dns#5611) - feat(source/pods): support for annotation and label filter by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5583](kubernetes-sigs/external-dns#5583) - feat(source): support --event flags with sources pod and node by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5642](kubernetes-sigs/external-dns#5642) - feat(source): use transformers in pod informers to reduce memory footprint by [@valerian-roche](https://github.com/valerian-roche) in [#5596](kubernetes-sigs/external-dns#5596) - feat(traefik)!: disable legacy listeners on traefik.containo.us API Group by [@mloiseleur](https://github.com/mloiseleur) in [#5565](kubernetes-sigs/external-dns#5565) #### 🐛 Bug fixes - fix(api): rollback oas and update linter by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5723](kubernetes-sigs/external-dns#5723) - fix(aws): support aws\_ca\_bundle by [@mwmix](https://github.com/mwmix) in [#5665](kubernetes-sigs/external-dns#5665) - fix(chart): Change .extraContainers type to array by [@svengreb](https://github.com/svengreb) in [#5564](kubernetes-sigs/external-dns#5564) - fix(cloudflare): display of action in logs by [@vflaux](https://github.com/vflaux) in [#5550](kubernetes-sigs/external-dns#5550) - fix(cloudflare): set comments properly by [@7onn](https://github.com/7onn) in [#5582](kubernetes-sigs/external-dns#5582) - fix(cloudflare): unnecessary record updates by [@vflaux](https://github.com/vflaux) in [#5770](kubernetes-sigs/external-dns#5770) - fix(controller): panic in events.Controller.Add() by [@vflaux](https://github.com/vflaux) in [#5766](kubernetes-sigs/external-dns#5766) - fix(docs): Fixing some errors in the dev-guide example. by [@mwmix](https://github.com/mwmix) in [#5662](kubernetes-sigs/external-dns#5662) - fix(endpoint): domains handling with idna by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5685](kubernetes-sigs/external-dns#5685) - fix(helm): resolve RBAC permissions for namespaced gateway sources by [@u-kai](https://github.com/u-kai) in [#5578](kubernetes-sigs/external-dns#5578) - fix(helm): Update helm value schema to allow `create-only` policy type by [@coltonhughes](https://github.com/coltonhughes) in [#5627](kubernetes-sigs/external-dns#5627) - fix(http): concurrent map read/write by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5753](kubernetes-sigs/external-dns#5753) - fix(instrumented\_http): migrate to own http instrumenter by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5650](kubernetes-sigs/external-dns#5650) - fix(metrics): make prometheus labels more type safe by [@mwmix](https://github.com/mwmix) in [#5717](kubernetes-sigs/external-dns#5717) - fix(oas): add required properties to api components by [@evilhamsterman](https://github.com/evilhamsterman) in [#5696](kubernetes-sigs/external-dns#5696) - fix(pihole): create record for all targets by [@vkolobara](https://github.com/vkolobara) in [#5584](kubernetes-sigs/external-dns#5584) - fix(provider/aws): null pointer when records mailformed by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5639](kubernetes-sigs/external-dns#5639) - fix(provider/aws-sd): fix namespace type filtering by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5682](kubernetes-sigs/external-dns#5682) - fix(provider): IDNA awareness in the zone finder by [@hanapedia](https://github.com/hanapedia) in [#5705](kubernetes-sigs/external-dns#5705) - fix(rbac): conditional endpointslices perms by [@vflaux](https://github.com/vflaux) in [#5746](kubernetes-sigs/external-dns#5746) - fix: reduce warning by using idna profile by [@szuecs](https://github.com/szuecs) in [#5587](kubernetes-sigs/external-dns#5587) - fix(rfc2136): Use correct index for accessing UpdateOld if there are multiple chunks by [@schwajo](https://github.com/schwajo) in [#5542](kubernetes-sigs/external-dns#5542) - fix(source): respect --expose-internal-ipv6 flag on NodePort services by [@jonasbadstuebner](https://github.com/jonasbadstuebner) in [#5652](kubernetes-sigs/external-dns#5652) - fix(source/service): disable node informer when not required by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5613](kubernetes-sigs/external-dns#5613) - fix(source/service): disable pod and endpointSlices informers when they are not needed by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5646](kubernetes-sigs/external-dns#5646) - fix(source/service): make sure only unique targets available for futher processing by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5614](kubernetes-sigs/external-dns#5614) - fix(txt-registry): skip creation of already-existing TXT records ([#4914](kubernetes-sigs/external-dns#4914)) by [@u-kai](https://github.com/u-kai) in [#5459](kubernetes-sigs/external-dns#5459) - fix: zonefinder used wrong quotation style by [@szuecs](https://github.com/szuecs) in [#5588](kubernetes-sigs/external-dns#5588) #### 📝 Documentation - docs: add information on external webhook usage by [@Raffo](https://github.com/Raffo) in [#5606](kubernetes-sigs/external-dns#5606) - docs: add new webhook provider SAKURA Cloud into README by [@ippanpeople](https://github.com/ippanpeople) in [#5784](kubernetes-sigs/external-dns#5784) - docs(aws): add helm repo command to the tutorial by [@raghu-manne](https://github.com/raghu-manne) in [#5618](kubernetes-sigs/external-dns#5618) - docs: fix typo in compatibility table by [@vflaux](https://github.com/vflaux) in [#5769](kubernetes-sigs/external-dns#5769) - docs(istio): document ingress annotation by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5756](kubernetes-sigs/external-dns#5756) - docs(providers): add Myra Security DNS to the list by [@armaaar](https://github.com/armaaar) in [#5671](kubernetes-sigs/external-dns#5671) - docs(readme): update k8s compatiblity table by [@vflaux](https://github.com/vflaux) in [#5747](kubernetes-sigs/external-dns#5747) - docs: remove substitution in AES keygen examples by [@super-octo-spoon](https://github.com/super-octo-spoon) in [#5686](kubernetes-sigs/external-dns#5686) - docs(source/service): headless records and root/base domain by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5624](kubernetes-sigs/external-dns#5624) #### 📦 Others - chore(ci): improve releaser script by [@mloiseleur](https://github.com/mloiseleur) in [#5571](kubernetes-sigs/external-dns#5571) - chore(ci): update labels automation by [@mloiseleur](https://github.com/mloiseleur) in [#5580](kubernetes-sigs/external-dns#5580) - chore(cloudflare): migrate CreateDNSRecord() to new lib by [@vflaux](https://github.com/vflaux) in [#5779](kubernetes-sigs/external-dns#5779) - chore(cloudflare): migrate DNSRecord to new lib struct by [@vflaux](https://github.com/vflaux) in [#5762](kubernetes-sigs/external-dns#5762) - chore(cloudflare): rename zoneService fields by [@vflaux](https://github.com/vflaux) in [#5761](kubernetes-sigs/external-dns#5761) - chore(cloudflare): upgrade library to v5 by [@vflaux](https://github.com/vflaux) in [#5734](kubernetes-sigs/external-dns#5734) - chore(cloudflare): use lib v4 for regional services by [@vflaux](https://github.com/vflaux) in [#5609](kubernetes-sigs/external-dns#5609) - chore(codebase): code reuse by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5607](kubernetes-sigs/external-dns#5607) - chore(codebase): enable linter nonamedreturns by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5594](kubernetes-sigs/external-dns#5594) - chore(codebase): remove pointer to an interface by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5625](kubernetes-sigs/external-dns#5625) - chore(deps): bump github.com/cloudflare/cloudflare-go/v4 from 4.5.1 to 4.6.0 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5645](kubernetes-sigs/external-dns#5645) - chore(deps): bump github.com/digitalocean/godo from 1.155.0 to 1.156.0 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5623](kubernetes-sigs/external-dns#5623) - chore(deps): bump github.com/oracle/oci-go-sdk/v65 from 65.94.0 to 65.95.0 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5597](kubernetes-sigs/external-dns#5597) - chore(deps): bump google.golang.org/api from 0.239.0 to 0.240.0 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5605](kubernetes-sigs/external-dns#5605) - chore(deps): bump renovatebot/github-action from 43.0.1 to 43.0.2 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5592](kubernetes-sigs/external-dns#5592) - chore(deps): bump renovatebot/github-action from 43.0.2 to 43.0.3 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5644](kubernetes-sigs/external-dns#5644) - chore(deps): bump renovatebot/github-action from 43.0.4 to 43.0.5 in the dev-dependencies group by [@app/dependabot](https://github.com/app/dependabot) in [#5691](kubernetes-sigs/external-dns#5691) - chore(deps): bump the dev-dependencies group across 1 directory with 10 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5760](kubernetes-sigs/external-dns#5760) - chore(deps): bump the dev-dependencies group across 1 directory with 17 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5704](kubernetes-sigs/external-dns#5704) - chore(deps): bump the dev-dependencies group across 1 directory with 17 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5726](kubernetes-sigs/external-dns#5726) - chore(deps): bump the dev-dependencies group across 1 directory with 18 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5739](kubernetes-sigs/external-dns#5739) - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5667](kubernetes-sigs/external-dns#5667) - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5732](kubernetes-sigs/external-dns#5732) - chore(deps): bump the dev-dependencies group across 1 directory with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5759](kubernetes-sigs/external-dns#5759) - chore(deps): bump the dev-dependencies group across 1 directory with 3 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5579](kubernetes-sigs/external-dns#5579) - chore(deps): bump the dev-dependencies group across 1 directory with 5 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5690](kubernetes-sigs/external-dns#5690) - chore(deps): bump the dev-dependencies group across 1 directory with 8 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5637](kubernetes-sigs/external-dns#5637) - chore(deps): bump the dev-dependencies group across 1 directory with 8 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5658](kubernetes-sigs/external-dns#5658) - chore(deps): bump the dev-dependencies group with 10 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5668](kubernetes-sigs/external-dns#5668) - chore(deps): bump the dev-dependencies group with 2 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5610](kubernetes-sigs/external-dns#5610) - chore(deps): bump the dev-dependencies group with 3 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5628](kubernetes-sigs/external-dns#5628) - chore(deps): bump the dev-dependencies group with 4 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5593](kubernetes-sigs/external-dns#5593) - chore(deps): bump the dev-dependencies group with 4 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5673](kubernetes-sigs/external-dns#5673) - chore(deps): bump the dev-dependencies group with 9 updates by [@app/dependabot](https://github.com/app/dependabot) in [#5763](kubernetes-sigs/external-dns#5763) - chore(deps): update golangci-lint version to v2.2.2 by [@dongjiang1989](https://github.com/dongjiang1989) in [#5670](kubernetes-sigs/external-dns#5670) - chore(endpoint): fix typo by [@bachorp](https://github.com/bachorp) in [#5787](kubernetes-sigs/external-dns#5787) - chore(github-actions): test execution with low resources by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5729](kubernetes-sigs/external-dns#5729) - chore(github): enchance issue-template for bug-report by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5692](kubernetes-sigs/external-dns#5692) - chore(helm): add rbac unit-tests for istio sources by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5752](kubernetes-sigs/external-dns#5752) - chore(metrics): refactor metrics to use common registry by [@mwmix](https://github.com/mwmix) in [#5677](kubernetes-sigs/external-dns#5677) - chore(plan): added tests for cases with asterisks by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5640](kubernetes-sigs/external-dns#5640) - chore(provider/aws): reduce if-nesting for dryRun condition by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5688](kubernetes-sigs/external-dns#5688) - chore: release chart for v0.18.0 by [@elafarge](https://github.com/elafarge) in [#5633](kubernetes-sigs/external-dns#5633) - chore(release): updates kustomize & docs with v0.18.0 by [@mloiseleur](https://github.com/mloiseleur) in [#5573](kubernetes-sigs/external-dns#5573) - chore(source/istio): replace kube API calls with caching and ingress informers by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5743](kubernetes-sigs/external-dns#5743) - chore(source/net-filter): improve flow logic and add more tests by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5629](kubernetes-sigs/external-dns#5629) - chore(source): reorganise sources and wrappers by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5598](kubernetes-sigs/external-dns#5598) - chore(source): use types instead of strings by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5699](kubernetes-sigs/external-dns#5699) - chore(store\*): add reduce complexity and improve code coverage by [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) in [#5568](kubernetes-sigs/external-dns#5568) - refactor(annotations): use common prefix to simplify filtering in informer transformers by [@valerian-roche](https://github.com/valerian-roche) in [#5621](kubernetes-sigs/external-dns#5621) - refactor(cloudflare): use lib v4 for zone services by [@AndrewCharlesHay](https://github.com/AndrewCharlesHay) in [#5654](kubernetes-sigs/external-dns#5654) - refactor(provider/cloudflare): use local regionalHostname struct by [@vflaux](https://github.com/vflaux) in [#5615](kubernetes-sigs/external-dns#5615) - refactor(source): document and add debug information on wrappers by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5687](kubernetes-sigs/external-dns#5687) - refactor(source/istio): add transformers by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5728](kubernetes-sigs/external-dns#5728) - refactor: use slices.Contains instead of handrolled for loop by [@szuecs](https://github.com/szuecs) in [#5589](kubernetes-sigs/external-dns#5589) - test: improve coverage on http and metrics by [@mwmix](https://github.com/mwmix) in [#5712](kubernetes-sigs/external-dns#5712) - test(source/istio): add missing edge cases with tests by [@ivankatliarchuk](https://github.com/ivankatliarchuk) in [#5715](kubernetes-sigs/external-dns#5715) - tests(source/crd): increase timeouts when it can randomly fails by [@vflaux](https://github.com/vflaux) in [#5785](kubernetes-sigs/external-dns#5785) #### 📦 Docker Image ``` docker pull registry.k8s.io/external-dns/external-dns:v0.19.0 ``` #### New Contributors - [@svengreb](https://github.com/svengreb) made their first contribution in [#5564](kubernetes-sigs/external-dns#5564) - [@schwajo](https://github.com/schwajo) made their first contribution in [#5542](kubernetes-sigs/external-dns#5542) - [@valerian-roche](https://github.com/valerian-roche) made their first contribution in [#5621](kubernetes-sigs/external-dns#5621) - [@chemi0213](https://github.com/chemi0213) made their first contribution in [#5638](kubernetes-sigs/external-dns#5638) - [@vkolobara](https://github.com/vkolobara) made their first contribution in [#5584](kubernetes-sigs/external-dns#5584) - [@raghu-manne](https://github.com/raghu-manne) made their first contribution in [#5618](kubernetes-sigs/external-dns#5618) - [@coltonhughes](https://github.com/coltonhughes) made their first contribution in [#5627](kubernetes-sigs/external-dns#5627) - [@elafarge](https://github.com/elafarge) made their first contribution in [#5633](kubernetes-sigs/external-dns#5633) - [@mwmix](https://github.com/mwmix) made their first contribution in [#5662](kubernetes-sigs/external-dns#5662) - [@super-octo-spoon](https://github.com/super-octo-spoon) made their first contribution in [#5686](kubernetes-sigs/external-dns#5686) - [@armaaar](https://github.com/armaaar) made their first contribution in [#5671](kubernetes-sigs/external-dns#5671) - [@hanapedia](https://github.com/hanapedia) made their first contribution in [#5705](kubernetes-sigs/external-dns#5705) - [@evilhamsterman](https://github.com/evilhamsterman) made their first contribution in [#5696](kubernetes-sigs/external-dns#5696) - [@dshatokhin](https://github.com/dshatokhin) made their first contribution in [#5737](kubernetes-sigs/external-dns#5737) - [@antchand](https://github.com/antchand) made their first contribution in [#5648](kubernetes-sigs/external-dns#5648) - [@ippanpeople](https://github.com/ippanpeople) made their first contribution in [#5784](kubernetes-sigs/external-dns#5784) - [@bachorp](https://github.com/bachorp) made their first contribution in [#5787](kubernetes-sigs/external-dns#5787) **Full Changelog**: <kubernetes-sigs/external-dns@v0.18.0...v0.19.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://codeberg.org/JesusMtnez/homelab/pulls/805 Co-authored-by: JesusMtnez-bot <jesusmartinez93+bot@gmail.com> Co-committed-by: JesusMtnez-bot <jesusmartinez93+bot@gmail.com>

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025

k8s-ci-robot requested review from stevehipwell and szuecs August 18, 2025 15:27

k8s-ci-robot added chart docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2025

stevehipwell suggested changes Aug 19, 2025

View reviewed changes

k8s-ci-robot assigned stevehipwell Aug 19, 2025

vflaux force-pushed the endpointslices_clusterroles branch from f2e6bd8 to 26bc061 Compare August 19, 2025 11:12

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2025

stevehipwell reviewed Aug 19, 2025

View reviewed changes

charts/external-dns/CHANGELOG.md Outdated Show resolved Hide resolved

fix(chart/rbac): conditional endpointslices perms and cleanup depreca…

de30762

…ted endpoints Only grant endpointslices permissions when using service source and remove outdated endpoints RBAC from provider tutorials. Add rbac tests for the chart.

vflaux force-pushed the endpointslices_clusterroles branch from 99068aa to de30762 Compare August 19, 2025 11:16

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025

k8s-ci-robot merged commit 8950e7d into kubernetes-sigs:master Aug 19, 2025
15 checks passed

vflaux deleted the endpointslices_clusterroles branch September 10, 2025 08:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rbac): conditional endpointslices perms#5746

fix(rbac): conditional endpointslices perms#5746
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
vflaux:endpointslices_clusterroles

vflaux commented Aug 18, 2025

Uh oh!

k8s-ci-robot commented Aug 18, 2025

Uh oh!

ivankatliarchuk commented Aug 19, 2025

Uh oh!

stevehipwell left a comment

Uh oh!

Uh oh!

stevehipwell commented Aug 19, 2025

Uh oh!

ivankatliarchuk commented Aug 19, 2025

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vflaux commented Aug 18, 2025

What does it do ?

Motivation

More

Uh oh!

k8s-ci-robot commented Aug 18, 2025

Uh oh!

ivankatliarchuk commented Aug 19, 2025

Uh oh!

stevehipwell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevehipwell commented Aug 19, 2025

Uh oh!

ivankatliarchuk commented Aug 19, 2025

Uh oh!

k8s-ci-robot commented Aug 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants