fix(cloudflare): set comments properly

[7onn]

What does it do ?

Comments were merged getting separated into another PR; a piece went missing, that prevented them from getting properly set.

Motivation

There's a bug on the current feature,

More

• Yes, this PR title follows Conventional Commits
• Yes, I added unit tests
• Yes, I updated end user documentation accordingly

[k8s-ci-robot]

Hi @7onn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivankatliarchuk]

/ok-to-test

[ivankatliarchuk]

Tests seems like needs adjusting. And make sure to share resutls of a smoke tests

[7onn]

Tests seems like needs adjusting. And make sure to share resutls of a smoke tests

What would you suggest as an adjustment? :)

About the tests, it seems working fine! but I just noticed one bug that was i.e. we can't erase comments due to pointer issues on the Comment field; Now I followed Cloudflare's suggestion to use their cloudflare.StringPtr(cfc.ResourceRecord.Comment). Will test again soon.

[mloiseleur]

/lgtm

[ivankatliarchuk]

Hi @7onn, have you manage to validate that everything is working without issues?

[7onn]

Hi @7onn, have you manage to validate that everything is working without issues?

Cloudflare-comment-wise, everything works perfectly now! Including the comment removal; before it was only possible to replace it with another content.

But I see some other warnings on my logs when testing this new version! It got confused by some other records in the zone it seems;

time="2025-07-14T08:52:00Z" level=warning msg="Got error while parsing DNSName _4000181a26befaf9a264796d0e0427f6.objects.cms.development.<redacted>: idna: disall
time="2025-07-14T08:52:00Z" level=warning msg="Got error while parsing DNSName _3c7277e9c446b1510677aadf3ed6c0b9.opensearch-v2-metrics.<redacted>: idna: disallow
time="2025-07-14T08:52:00Z" level=warning msg="Got error while parsing DNSName _b1b952d7042b15b143cba4e9c2cac528.cdn.s.<redacted>: idna: disallowed rune U+005F" 
time="2025-07-14T08:52:00Z" level=warning msg="Got error while parsing DNSName _7ab1d7a97d96950644f114ba43159f58.content.<redacted>: idna: disallowed rune U+005F

Another that i had to tweak manually, idk why, was the lack of permissions to read EndpointSlices 🤔 Had to patch my cluster role manually (as I haven't pulled the new helm chart version) to make it work.

Anyway, I'm confident to merge this as it proved to have fixed what went missing on the last PR;

Another thing that seems off but not related to these changes is the comprehensiveness when commenting record; one seemed to be left out

[ivankatliarchuk]

Good to know. Thanks

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ivankatliarchuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment