TestTaintsUpdated: Drop errChan, it's usefull only during the startup#585
Closed
ingvagabund wants to merge 1 commit intokubernetes-sigs:masterfrom
Closed
TestTaintsUpdated: Drop errChan, it's usefull only during the startup#585ingvagabund wants to merge 1 commit intokubernetes-sigs:masterfrom
ingvagabund wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
Otherwise, one can get: ``` panic: send on closed channel goroutine 76 [running]: sigs.k8s.io/descheduler/pkg/descheduler.TestTaintsUpdated.func1(0x2d1b390, 0xc000126010, 0xc0000d8c60, 0xc00038fbd0, 0xc000111320, 0xc000239380) /home/travis/gopath/src/github.com/openshift/descheduler/_output/local/go/src/sigs.k8s.io/descheduler/pkg/descheduler/descheduler_test.go:51 +0xbe created by sigs.k8s.io/descheduler/pkg/descheduler.TestTaintsUpdated /home/travis/gopath/src/github.com/openshift/descheduler/_output/local/go/src/sigs.k8s.io/descheduler/pkg/descheduler/descheduler_test.go:49 +0x6db FAIL sigs.k8s.io/descheduler/pkg/descheduler 0.845s ```
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
damemi
reviewed
Jun 9, 2021
|
|
||
| go func() { | ||
| err := RunDeschedulerStrategies(ctx, rs, dp, "v1beta1", stopChannel) | ||
| errChan <- err |
Member
There was a problem hiding this comment.
I don't think we should remove this pattern entirely (from when it was added in #568)
Rather, I think the panic you're seeing could be fixed by moving the nil check to here from L55, so we're not always sending nil over this channel. wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, one can get: