Add verify script for govet & fix pkg/descheduler/descheduler_test.go

[binacs]

We can only use t.Fatal in the main test goroutine.

The solution is similar to:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/app/server_test.go#L501

Thanks for review!

[lixiang233]

I think this comment is useful, can you keep it?

[binacs]

Done.
Thanks for review ^-^

[lixiang233]

/lgtm

[damemi]

Could you share what the failure is for this? I don't think we currently run staticcheck in our CI, if not this would be a good PR to add that check

[binacs]

Could you share what the failure is for this? I don't think we currently run staticcheck in our CI, if not this would be a good PR to add that check

Hi @damemi , the failure is call to (*T).Fatalf from a non-test goroutine:

More about the failure at: https://golang.org/doc/go1.16#vet

And I will do some work about staticcheck as soon as possible.

[damemi]

@BinacsLee ah, I see, so this is a failure from go vet. The title made me think this was coming from something like verify-staticcheck.sh.

In that case, let's update this PR to add a script to verify go vet, similar to https://github.com/kubernetes/kubernetes/blob/master/hack/verify-govet.sh. We can have that script run as part of make verify, which will include it in our CI runs so we can catch things like this automatically in the future. As an example, you can see how we added verify scripts in some other PRs like #545

(For context I do see the error when running go vet):

$ go vet ./pkg/...
# sigs.k8s.io/descheduler/pkg/descheduler
pkg/descheduler/descheduler_test.go:50:4: call to (*T).Fatalf from a non-test goroutine

[binacs]

I'm sorry to confuse you. The script for govet has been added. Let's see how CI turns out ^-^

[damemi]

@BinacsLee no problem! Thanks for the update, this looks good to me now
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BinacsLee, damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damemi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment