Skip to content

nit: fix log to replace Creating with Preparing #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Apr 4, 2019
Merged

nit: fix log to replace Creating with Preparing #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/clusterctl/phases/createbootstrapcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
)

func CreateBootstrapCluster(provisioner bootstrap.ClusterProvisioner, cleanupBootstrapCluster bool, clientFactory clusterclient.Factory) (clusterclient.Client, func(), error) {
klog.Info("Creating bootstrap cluster")
klog.Info("Preparing bootstrap cluster")
Copy link
Copy Markdown
Contributor

@gyliu513 gyliu513 Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit confused, this log is in the function of CreateBootstrapCluster, I think using Creating should be OK?

For your case, are you running clusterctl without creating bootstrap cluster? If so, can we avoid calling this function when using existing cluster?

Copy link
Copy Markdown
Member

@vincepri vincepri Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fix is for when using the existing bootstrap cluster type, which it makes sense. It's a small change that works for any bootstrapper type.

Copy link
Copy Markdown
Contributor Author

@jichenjc jichenjc Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's a nit and not important ,just better to have
since it take me some time to know it's not 'creating' at all, it's just preparing (either creating or reusing)

Copy link
Copy Markdown
Contributor

@gyliu513 gyliu513 Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this make sense, thanks @jichenjc @vincepri


cleanupFn := func() {}
if err := provisioner.Create(); err != nil {
Expand Down