nit: fix log to replace Creating with Preparing by jichenjc · Pull Request #872 · kubernetes-sigs/cluster-api

jichenjc · 2019-04-03T09:34:25Z

saw this log with following flag
--bootstrap-cluster-kubeconfig /root/.kube/config

I0403 17:32:28.339021 31615 createbootstrapcluster.go:27] Creating bootstrap cluster

actually we are reusing ,not creating

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

saw this log with following flag --bootstrap-cluster-kubeconfig /root/.kube/config I0403 17:32:28.339021 31615 createbootstrapcluster.go:27] Creating bootstrap cluster actually we are reusing ,not creating

detiber · 2019-04-03T13:14:02Z

/lgtm
/assign @vincepri

gyliu513 · 2019-04-03T13:17:32Z

cmd/clusterctl/phases/createbootstrapcluster.go


 func CreateBootstrapCluster(provisioner bootstrap.ClusterProvisioner, cleanupBootstrapCluster bool, clientFactory clusterclient.Factory) (clusterclient.Client, func(), error) {
-	klog.Info("Creating bootstrap cluster")
+	klog.Info("Preparing bootstrap cluster")


I was a bit confused, this log is in the function of CreateBootstrapCluster, I think using Creating should be OK?

For your case, are you running clusterctl without creating bootstrap cluster? If so, can we avoid calling this function when using existing cluster?

I think the fix is for when using the existing bootstrap cluster type, which it makes sense. It's a small change that works for any bootstrapper type.

yes, it's a nit and not important ,just better to have
since it take me some time to know it's not 'creating' at all, it's just preparing (either creating or reusing)

this make sense, thanks @jichenjc @vincepri

vincepri

/approve

vincepri · 2019-04-03T16:22:32Z

cmd/clusterctl/phases/createbootstrapcluster.go


 func CreateBootstrapCluster(provisioner bootstrap.ClusterProvisioner, cleanupBootstrapCluster bool, clientFactory clusterclient.Factory) (clusterclient.Client, func(), error) {
-	klog.Info("Creating bootstrap cluster")
+	klog.Info("Preparing bootstrap cluster")


I think the fix is for when using the existing bootstrap cluster type, which it makes sense. It's a small change that works for any bootstrapper type.

k8s-ci-robot · 2019-04-03T16:22:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

detiber · 2019-04-03T16:40:44Z

/test pull-cluster-api-test

jichenjc · 2019-04-04T14:56:02Z

/test pull-cluster-api-test

jichenjc · 2019-04-04T14:56:14Z

/retest

jichenjc · 2019-04-04T14:56:54Z

@gyliu513 maybe you can help to lgtm?

gyliu513 · 2019-04-04T15:11:37Z

/lgtm

saw this log with following flag --bootstrap-cluster-kubeconfig /root/.kube/config I0403 17:32:28.339021 31615 createbootstrapcluster.go:27] Creating bootstrap cluster actually we are reusing ,not creating

* Update CRDs (#863) Generated with `make generate` * fix various shell bugs (#868) * fix errors in scripts/ci-build.gitsh * fix errors in scripts/ci-integration.sh * fix errors in scripts/ci-is-vendor-in-sync.sh * fix errors in scripts/ci-make.sh * fix errors in scripts/ci-test.sh * removed unused variables from scripts/fetch_ext_bins.sh * fix errors in hack/update-bazel.sh * fix errors in hack/verify_clientset.sh * use gnu sed on all platforms (#867) * Fix error message in getCluster (#871) Previously it was showing 'Machine foo in namespace "cluster.k8s.io/cluster-name" doesn't specify "k8s-machine-api" label, assuming nil cluster' * minikube: use --profile instead of --p (#875) It was reported that "minikube start" fails: minikube start --bootstrapper=kubeadm --p=clusterapi Error: unknown flag: --p From "minikube start --help": -p, --profile string Use --profile in minikube.go as --p does not work. The alternative is -p. * nit: fix log to replace Creating with Preparing (#872) saw this log with following flag --bootstrap-cluster-kubeconfig /root/.kube/config I0403 17:32:28.339021 31615 createbootstrapcluster.go:27] Creating bootstrap cluster actually we are reusing ,not creating * Record machine sync error event (#880) * make clusterapi wait timeout configurable (#865) add an environment to make timeout configurable for timeoutMachineReady * Update klog to 0.3.0 release (#890) Signed-off-by: Vince Prignano <vincepri@vmware.com> * Add missing namespace to Get function (#896) * Add NodeName to Machine's additionalPrinterColumns (#895) Because it is useful to cross-reference between Machines and Nodes. Set priority to >0 so that node names will only be displayed in `-o wide` because the names are often quite long. * additionalPrinterColumns for Machine, added correctly. (#897) Co-authored-by: Danny Berger <dberger@pivotal.io> * Normalize clusterctl options to underscores (#899) Matches current conventions and implementation of kubectl. This change does not include warning messages when using the previous, underscore option names, but it does recognize those names. Co-authored-by: Leah Hanson <lhanson@pivotal.io> * Update manager-role ClusterRole (#901) * Update Go 1.12 (#898) * Update Go 1.12 Signed-off-by: Vince Prignano <vincepri@vmware.com> * update Signed-off-by: Vince Prignano <vincepri@vmware.com> * Update OWNERS_ALIASES and SECURITY_CONTACTS (#884) * Update OWNERS_ALIASES and SECURITY_CONTACTS * Add davidewatson to cluster-api-admins * Clarify log message for machine-controller isDeleteAllowed (#905) Users have noted that this log message is confusing and does not lead to a clear path forward when deleting this machine. This commit makes it clear that the machine will not be deleted. * Clarify MachineDeployment watchers' comments (#887) Signed-off-by: Vince Prignano <vincepri@vmware.com> * Simplify util.ParseMachinesYaml (#909) Signed-off-by: Vince Prignano <vincepri@vmware.com> * Add support for passing namespace cmdline flag to the manager (#914) * Bump kubectl version to v1.13.2 in ci (#923) kubectl v1.10.2 does not compatible with cluster v1.14.x anymore Signed-off-by: Hui Luo <luoh@vmware.com> * Add /status to MachineSet and MachineDeployment kubebuilder directives (#922) Signed-off-by: Vince Prignano <vincepri@vmware.com>

nit: fix log to replace Creating with Preparing

1e09c68

saw this log with following flag --bootstrap-cluster-kubeconfig /root/.kube/config I0403 17:32:28.339021 31615 createbootstrapcluster.go:27] Creating bootstrap cluster actually we are reusing ,not creating

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2019

k8s-ci-robot requested review from krousey and vincepri April 3, 2019 09:34

k8s-ci-robot assigned detiber and vincepri Apr 3, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2019

gyliu513 reviewed Apr 3, 2019

View reviewed changes

vincepri approved these changes Apr 3, 2019

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019

k8s-ci-robot assigned gyliu513 Apr 4, 2019

k8s-ci-robot merged commit b90a4cc into kubernetes-sigs:master Apr 4, 2019

Conversation

jichenjc commented Apr 3, 2019

Uh oh!

detiber commented Apr 3, 2019

Uh oh!

gyliu513 Apr 3, 2019

Choose a reason for hiding this comment

Uh oh!

vincepri Apr 3, 2019

Choose a reason for hiding this comment

Uh oh!

jichenjc Apr 4, 2019

Choose a reason for hiding this comment

Uh oh!

gyliu513 Apr 4, 2019

Choose a reason for hiding this comment

Uh oh!

vincepri left a comment

Choose a reason for hiding this comment

Uh oh!

vincepri Apr 3, 2019

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Apr 3, 2019

Uh oh!

detiber commented Apr 3, 2019

Uh oh!

jichenjc commented Apr 4, 2019

Uh oh!

jichenjc commented Apr 4, 2019

Uh oh!

jichenjc commented Apr 4, 2019

Uh oh!

gyliu513 commented Apr 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments