Skip to content

🐛 Fix SecurityGroupInUse error #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Dec 10, 2020
+19 −0
Merged

🐛 Fix SecurityGroupInUse error #705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkg/cloud/services/compute/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,9 @@ func (s *Service) createInstance(clusterName string, i *infrav1.Instance) (*infr
KeyName: i.SSHKeyName,
}).Extract()
if err != nil {
if errd := deletePorts(s, portsList); errd != nil {
return nil, fmt.Errorf("error recover creating Openstack instance: %v", errd)
}
return nil, fmt.Errorf("error creating Openstack instance: %v", err)
}
instanceCreateTimeout := getTimeout("CLUSTER_API_OPENSTACK_INSTANCE_CREATE_TIMEOUT", TimeoutInstanceCreate)
Expand Down Expand Up @@ -481,6 +484,22 @@ func createPort(is *Service, clusterName string, name string, net *infrav1.Netwo
return *newPort, nil
}

func deletePorts(s *Service, nets []servers.Network) error {

for _, n := range nets {
_, err := ports.Get(s.networkClient, n.Port).Extract()
if err != nil {
if capoerrors.IsNotFound(err) {
return nil
}
}
if err := ports.Delete(s.networkClient, n.Port).ExtractErr(); err != nil {
return err
}
}
return nil
}

// Helper function for getting image ID from name
func getImageID(is *Service, imageName string) (string, error) {
if imageName == "" {
Expand Down