Skip to content

🐛 Fix SecurityGroupInUse error#705

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
hidekazuna:security_group_in_use
Dec 10, 2020
Merged

🐛 Fix SecurityGroupInUse error#705
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
hidekazuna:security_group_in_use

Conversation

@hidekazuna
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

This PR deletes port when an instance creation is not executed such as cpu quota error.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #701

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 8, 2020
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 8, 2020

Build failed.

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Dec 9, 2020

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 9, 2020

Build failed.

@jichenjc
Copy link
Copy Markdown
Contributor

recheck

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 10, 2020

Build failed.

This commit deletes port when an instance can not be created due to cpu
cores quota error.
@hidekazuna hidekazuna force-pushed the security_group_in_use branch from ab59234 to f23fcc2 Compare December 10, 2020 05:10
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Dec 10, 2020

Build succeeded.

@jichenjc
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4a15cdd into kubernetes-sigs:master Dec 10, 2020
@hidekazuna hidekazuna deleted the security_group_in_use branch December 10, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SecurityGroupInUse error

3 participants