fix for pr590 wrong parameter for a user provider network by pramchan · Pull Request #594 · kubernetes-sigs/cluster-api-provider-openstack

pramchan · 2020-07-21T00:32:44Z

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

k8s-ci-robot · 2020-07-21T00:32:47Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-07-21T00:32:52Z

Welcome @pramchan!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-07-21T00:32:52Z

Hi @pramchan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-07-21T00:32:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pramchan
To complete the pull request process, please assign justinsb
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jichenjc · 2020-07-21T01:13:24Z

/ok-to-test

jichenjc · 2020-07-21T01:14:09Z

controllers/openstackcluster_controller.go


 		netOpts := networks.ListOpts(openStackCluster.Spec.Network)
 		networkList, err := networkingService.GetNetworksByFilter(&netOpts)
-		if err != nil && len(networkList) == 0 {


does this change really fix the nil reference in the bug?

jichenjc · 2020-07-21T01:15:22Z

you need sign cncf-cla?

theopenlab-ci · 2020-07-21T01:37:01Z

Build succeeded.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : SUCCESS in 1h 02m 55s

hidekazuna · 2020-07-21T01:38:25Z

controllers/openstackcluster_controller.go

+		if len(networkList) == 0 {
+			return errors.Errorf("failed to find any network: %v", err)
+		}
+		if err != nil {


It is better to check err is nil or not before checking networkList == 0.

hidekazuna · 2020-07-21T01:41:15Z

@pramchan Please update

Fixes #

to

Fixes #590

nit: Add default egress rule description

pramchan · 2020-07-22T17:23:08Z

Modified code to address the changes suggested...
<<<<<<< Updated upstream
if len(networkList) == 0 {
return errors.Errorf("failed to find any network: %v", err)
}

Stashed changes
if err != nil {
return errors.Errorf("failed to find network: %v", err)
}
if len(networkList) <= 0 {
return errors.Errorf("failed to find any network: %v", err)
}
if len(networkList) > 1 {
return errors.Errorf("failed to find only one network (result: %v): %v", networkList, err)
}

pramchan · 2020-07-22T17:27:04Z

Do I need to create a new pull again for some changes?
https://github.com/pramchan/cluster-api-provider-openstack

ncdc · 2020-07-22T17:35:20Z

@pramchan you generally never need to create a new pull request

…etes-sigs#594

…s-sigs#594

k8s-ci-robot · 2020-07-22T19:03:00Z

@pramchan: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-provider-openstack-test	`7cee975`	link	`/test pull-cluster-api-provider-openstack-test`
pull-cluster-api-provider-openstack-build	`7cee975`	link	`/test pull-cluster-api-provider-openstack-build`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

theopenlab-ci · 2020-07-22T19:34:47Z

Build failed.

cluster-api-provider-openstack-current-acceptance-test-v1.18 : FAILURE in 33m 26s

hidekazuna · 2020-07-23T02:16:21Z

Do I need to create a new pull again for some changes?
https://github.com/pramchan/cluster-api-provider-openstack

@pramchan No, you do not need to create a new PR generally. But your PR now includes the code of some PRs already merged. https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/594/files, so
if current situation is complicated for you, close this PR and create a new PR by following https://github.com/kubernetes/community/blob/master/contributors/guide/github-workflow.md.

… user provider network

fejta-bot · 2020-10-21T02:58:57Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

hidekazuna · 2020-10-21T08:08:28Z

This PR was replaced by #610
/close

k8s-ci-robot · 2020-10-21T08:08:36Z

@hidekazuna: Closed this PR.

Details

In response to this:

This PR was replaced by #610
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

✨ My594 revised #590 #594 wrong parameter for a user provider network

… user provider network

fix for pr590 wrong parameter for a user provider network

a3188f4

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 21, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2020

k8s-ci-robot requested review from m1093782566 and ncdc July 21, 2020 00:32

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2020

jichenjc reviewed Jul 21, 2020

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 21, 2020

hidekazuna reviewed Jul 21, 2020

View reviewed changes

jichenjc and others added 3 commits July 22, 2020 02:56

nit: Add default egress rule description

32c161f

Merge pull request kubernetes-sigs#585 from jichenjc/add_description

edb84c1

nit: Add default egress rule description

Merge https://github.com/pramchan/cluster-api-provider-openstack

4fd3003

re-fixing for pr590 wrong parameter fora user provider newtork kubern…

8b30361

…etes-sigs#594

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 22, 2020

refix for pr590 wrong parameter for a user provider network kubernete…

7cee975

…s-sigs#594

pramchan added a commit to pramchan/cluster-api-provider-openstack that referenced this pull request Aug 6, 2020

revised kubernetes-sigs#590 kubernetes-sigs#594 wrong parameter for a…

c528add

… user provider network

pramchan mentioned this pull request Aug 6, 2020

✨ My594 revised #590 #594 wrong parameter for a user provider network #610

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2020

k8s-ci-robot closed this Oct 21, 2020

k8s-ci-robot added a commit that referenced this pull request Oct 21, 2020

Merge pull request #610 from pramchan/my594

1ead086

✨ My594 revised #590 #594 wrong parameter for a user provider network

EmilienM mentioned this pull request Jan 31, 2023

Manual rebase on upstream openshift/cluster-api-provider-openstack#252

Closed

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024

revised kubernetes-sigs#590 kubernetes-sigs#594 wrong parameter for a…

bd59a56

… user provider network

Conversation

pramchan commented Jul 21, 2020

Uh oh!

k8s-ci-robot commented Jul 21, 2020

Uh oh!

k8s-ci-robot commented Jul 21, 2020

Uh oh!

k8s-ci-robot commented Jul 21, 2020

Uh oh!

k8s-ci-robot commented Jul 21, 2020

Uh oh!

jichenjc commented Jul 21, 2020

Uh oh!

jichenjc Jul 21, 2020

Choose a reason for hiding this comment

Uh oh!

jichenjc commented Jul 21, 2020

Uh oh!

theopenlab-ci bot commented Jul 21, 2020

Uh oh!

hidekazuna Jul 21, 2020

Choose a reason for hiding this comment

Uh oh!

hidekazuna commented Jul 21, 2020

Uh oh!

pramchan commented Jul 22, 2020

Modified code to address the changes suggested... <<<<<<< Updated upstream if len(networkList) == 0 { return errors.Errorf("failed to find any network: %v", err) }

Uh oh!

pramchan commented Jul 22, 2020

Uh oh!

ncdc commented Jul 22, 2020

Uh oh!

k8s-ci-robot commented Jul 22, 2020

Uh oh!

theopenlab-ci bot commented Jul 22, 2020

Uh oh!

hidekazuna commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fejta-bot commented Oct 21, 2020

Uh oh!

hidekazuna commented Oct 21, 2020

Uh oh!

k8s-ci-robot commented Oct 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Modified code to address the changes suggested...
<<<<<<< Updated upstream
if len(networkList) == 0 {
return errors.Errorf("failed to find any network: %v", err)
}

hidekazuna commented Jul 23, 2020 •

edited

Loading