nit: Add default egress rule description#585
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom Jul 22, 2020
Merged
nit: Add default egress rule description#585k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Build failed.
|
hidekazuna
reviewed
Jul 13, 2020
Contributor
hidekazuna
left a comment
hidekazuna
left a comment
There was a problem hiding this comment.
I think description should represent the rule. Full open or All open, or something.
jichenjc
force-pushed
the
add_description
branch
from
a94820e to
2f49670
Compare
|
Build failed.
|
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
Author
|
/test pull-cluster-api-provider-openstack-build |
jichenjc
force-pushed
the
add_description
branch
from
2f49670 to
32c161f
Compare
k8s-ci-robot
removed
the
lgtm
|
Build succeeded.
|
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: