Skip to content

install kustomize via install script instead of go get#495

Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
sbueringer:pr-fix-kustomize-for-tests
Jan 3, 2020
Merged

install kustomize via install script instead of go get#495
k8s-ci-robot merged 2 commits intokubernetes-sigs:masterfrom
sbueringer:pr-fix-kustomize-for-tests

Conversation

@sbueringer
Copy link
Member

Fixes the kustomize installation to fix our test errors because of failed kustomize go get's

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2020
@sbueringer sbueringer force-pushed the pr-fix-kustomize-for-tests branch from df4a95d to 2f02eea Compare January 3, 2020 15:59
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2020
@sbueringer
Copy link
Member Author

@ncdc okay seems to work now, can you take another look?

/assign @ncdc

@ncdc
Copy link
Contributor

ncdc commented Jan 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0f02622 into kubernetes-sigs:master Jan 3, 2020
@sbueringer sbueringer deleted the pr-fix-kustomize-for-tests branch January 3, 2020 16:13
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
…gs#495)

* install kustomize via install script instead of go get

* fixup tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants