Skip to content

Comments

enhance doc regarding to manually delete cluster#494

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
huxiaoliang:fix-doc
Jan 5, 2020
Merged

enhance doc regarding to manually delete cluster#494
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
huxiaoliang:fix-doc

Conversation

@huxiaoliang
Copy link
Contributor

@huxiaoliang huxiaoliang commented Dec 26, 2019

fix #493

What this PR does / why we need it:

create a k8s cluster with 1 master node and 1 worker node, then manually delete this cluster according to doc here , but it doesn't work, this is due to no label like set=node and set=master on the Machine resource.
Fixes #493

Special notes for your reviewer:

None

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 26, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @huxiaoliang!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @huxiaoliang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from chrigl and ncdc December 26, 2019 05:09
@ncdc
Copy link
Contributor

ncdc commented Jan 2, 2020

LGTM (I think 😄) but you'll need to update your commit message so it doesn't say fix.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2020
@huxiaoliang huxiaoliang changed the title fix doc issue enhance doc regarding to manually delete cluster Jan 3, 2020
@huxiaoliang
Copy link
Contributor Author

/retest

@sbueringer
Copy link
Member

/approve

looks good. Seems to be an issue with go get'ing kustomize. I'll take a look later today

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huxiaoliang, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2020
@sbueringer
Copy link
Member

@huxiaoliang This PR should fix the tests: #495

When this PR is merged you only have to rebase onto master to fix the tests.

@sbueringer
Copy link
Member

/retest

@sbueringer
Copy link
Member

@huxiaoliang Okay so rebase wasn't necessary for the tests because Prow tests a combination of master and a PR. But you have to change the commit message.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 5, 2020
@huxiaoliang
Copy link
Contributor Author

@sbueringer @ncdc invalid commit message get removed just now, thanks for your review.

@sbueringer
Copy link
Member

Thx :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit a35e2cd into kubernetes-sigs:master Jan 5, 2020
@huxiaoliang huxiaoliang deleted the fix-doc branch January 5, 2020 11:45
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

manually delete cluster doesn't work against doc described

4 participants