enhance doc regarding to manually delete cluster#494
enhance doc regarding to manually delete cluster#494k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
Conversation
|
Welcome @huxiaoliang! |
|
Hi @huxiaoliang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM (I think 😄) but you'll need to update your commit message so it doesn't say /ok-to-test |
|
/retest |
|
/approve looks good. Seems to be an issue with go get'ing kustomize. I'll take a look later today |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: huxiaoliang, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@huxiaoliang This PR should fix the tests: #495 When this PR is merged you only have to rebase onto master to fix the tests. |
|
/retest |
|
@huxiaoliang Okay so rebase wasn't necessary for the tests because Prow tests a combination of master and a PR. But you have to change the commit message. |
|
@sbueringer @ncdc invalid commit message get removed just now, thanks for your review. |
|
Thx :) /lgtm |
fix #493
What this PR does / why we need it:
create a k8s cluster with 1 master node and 1 worker node, then manually delete this cluster according to doc here , but it doesn't work, this is due to no label like set=node and set=master on the Machine resource.
Fixes #493
Special notes for your reviewer:
None