Skip to content

🐛 allow switching from filter.name to id of network and subnets in OSC spec#2540

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.12from
k8s-infra-cherrypick-robot:cherry-pick-2518-to-release-0.12
May 12, 2025
Merged

🐛 allow switching from filter.name to id of network and subnets in OSC spec#2540
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.12from
k8s-infra-cherrypick-robot:cherry-pick-2518-to-release-0.12

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #2518

/assign mnaser

/cherrypick release-0.11 release-0.10

@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit c81d89e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/681e0d2ae810bd0008dcc9b7
😎 Deploy Preview https://deploy-preview-2540--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 May 9, 2025 14:11
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mdbooth May 9, 2025 14:11
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2025
@mnaser
Copy link
Contributor

mnaser commented May 9, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@lentzi90
Copy link
Contributor

lentzi90 commented May 9, 2025

Technically we should not backport "features" (:sparkles: ). On the other hand, we can probably consider this a bug :bug: and then it is fine to backport

@mnaser
Copy link
Contributor

mnaser commented May 9, 2025

I think it's more of a bug than a feature to be honest, since this blocks our ability to upgrade clusters when we transitioned to using IDs instead of names to be honest.

@lentzi90
Copy link
Contributor

/retitle [release-0.12] 🐛 allow switching from filter.name to id of network and subnets in OSC spec

@k8s-ci-robot k8s-ci-robot changed the title [release-0.12] ✨ allow switching from filter.name to id of network and subnets in OSC spec [release-0.12] 🐛 allow switching from filter.name to id of network and subnets in OSC spec May 12, 2025
@lentzi90
Copy link
Contributor

/retitle 🐛 allow switching from filter.name to id of network and subnets in OSC spec

@k8s-ci-robot k8s-ci-robot changed the title [release-0.12] 🐛 allow switching from filter.name to id of network and subnets in OSC spec 🐛 allow switching from filter.name to id of network and subnets in OSC spec May 12, 2025
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I'm fine treating this as a bug also

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 44aedf7 into kubernetes-sigs:release-0.12 May 12, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Inbox to Done in CAPO Roadmap May 12, 2025
@k8s-infra-cherrypick-robot
Copy link
Author

@k8s-infra-cherrypick-robot: new pull request created: #2541

Details

In response to this:

This is an automated cherry-pick of #2518

/assign mnaser

/cherrypick release-0.11 release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants