🐛 allow switching from filter.name to id of network and subnets in OSC spec#2540
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
|
Technically we should not backport "features" (:sparkles: ). On the other hand, we can probably consider this a bug :bug: and then it is fine to backport |
|
I think it's more of a bug than a feature to be honest, since this blocks our ability to upgrade clusters when we transitioned to using IDs instead of names to be honest. |
|
/retitle [release-0.12] 🐛 allow switching from filter.name to id of network and subnets in OSC spec |
|
/retitle 🐛 allow switching from filter.name to id of network and subnets in OSC spec |
lentzi90
left a comment
There was a problem hiding this comment.
/approve
I'm fine treating this as a bug also
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@k8s-infra-cherrypick-robot: new pull request created: #2541 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #2518
/assign mnaser
/cherrypick release-0.11 release-0.10