✨ allow switching from filter.name to id of network and subnets in OSC spec

[okozachenko1203]

What this PR does / why we need it:
This PR allows switching from spec.network.filter.name to spec.network.id in OpenstackCluster webhook.
Same for spec.subnets.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[k8s-ci-robot]

Hi @okozachenko1203. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	417ac30
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/68141fffe903e30008a245d2
😎 Deploy Preview	https://deploy-preview-2518--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[lentzi90]

/ok-to-test
Seems safe and ok to me
/lgtm

[lentzi90]

I think the test failure is due to a typo. It should be capital N in Spec.Network

[mnaser]

@okozachenko1203 do you think we can somehow exercise this in any sort of test to allow validating the change?

[mnaser]

Looking at the tests, I see we can use this here:

https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/pkg/webhooks/openstackcluster_webhook_test.go

[okozachenko1203]

/ok-to-test

[mnaser]

/ok-to-test

@okozachenko1203 just FYI, you need to be a member of the kubernetes-sigs GitHub org in order to be able to run that.

[mnaser]

/lgtm

[EmilienM]

I'm not against this PR but why don't we also do Subnets and other resources in that case?

[lentzi90]

Please squash the commits.
@EmilienM also has a good point. Why do it only for network? We could do this for all resources that follow the same pattern

[okozachenko1203]

@EmilienM @lentzi90 please review again

[lentzi90]

/approve

[mdbooth]

This is great.

I would still really like to ditch the webhooks and replace it all with CEL. I don't think we're currently doing anything that can't be defined in CEL. This would be one of the more interesting examples, though!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lentzi90,mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lentzi90]

/hold cancel

[mnaser]

/cherry-pick release-0.12 release-0.11 release-0.10

[k8s-infra-cherrypick-robot]

@mnaser: new pull request created: #2540

Details

In response to this:

/cherry-pick release-0.12 release-0.11 release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[okozachenko1203]

/cherry-pick release-0.11

[k8s-infra-cherrypick-robot]

@okozachenko1203: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

Details

In response to this:

/cherry-pick release-0.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.