Skip to content

Add opt to use AZ for APISeverLoadBalancer #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nguyenhuukhoi wants to merge 3 commits into from
Closed

Add opt to use AZ for APISeverLoadBalancer #1979

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c70693c
Add opt to use AZ for APISeverLoadBalancer
nguyenhuukhoi Mar 28, 2024
dfbc3ef
Add opt to use AZ for APISeverLoadBalancer
nguyenhuukhoi Mar 28, 2024
2cb079c
Merge pull request #1 from dulek/nguyenhuukhoi/main
nguyenhuukhoi Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/v1alpha5/zz_generated.conversion.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions api/v1alpha6/zz_generated.conversion.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions api/v1alpha7/zz_generated.conversion.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions api/v1beta1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,10 @@ type APIServerLoadBalancer struct {
// specified.
// +optional
Provider optional.String `json:"provider,omitempty"`

// AvailabilityZone is the failure domain that will be used to create the APIServerLoadBalancer Spec.
//+optional
AvailabilityZone optional.String `json:"availabilityZone,omitempty"`
}

func (s *APIServerLoadBalancer) IsZero() bool {
Expand Down
5 changes: 5 additions & 0 deletions api/v1beta1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclustertemplates.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions docs/book/src/api/v1beta1/api.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pkg/cloud/services/loadbalancer/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ func (s *Service) getOrCreateAPILoadBalancer(openStackCluster *infrav1.OpenStack
if err != nil {
return nil, err
}
availabilityZone := openStackCluster.Spec.APIServerLoadBalancer.AvailabilityZone

lbCreateOpts := loadbalancers.CreateOpts{
Name: loadBalancerName,
Expand All @@ -306,6 +307,9 @@ func (s *Service) getOrCreateAPILoadBalancer(openStackCluster *infrav1.OpenStack
Provider: lbProvider,
Tags: openStackCluster.Spec.Tags,
}
if availabilityZone != nil {
lbCreateOpts.AvailabilityZone = *availabilityZone
}
if vipAddress != nil {
lbCreateOpts.VipAddress = *vipAddress
}
Expand Down