Skip to content

Add opt to use AZ for APISeverLoadBalancer #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nguyenhuukhoi wants to merge 3 commits into from
Closed

Add opt to use AZ for APISeverLoadBalancer #1979

nguyenhuukhoi wants to merge 3 commits into from

Conversation

@nguyenhuukhoi
Copy link
Contributor

@nguyenhuukhoi nguyenhuukhoi commented Mar 28, 2024

What this PR does / why we need it: We need this option to use in case of having edge

This PR allows to choose AZ for API Load Balancer. It will be useful if we want to use edge sites,

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nguyenhuukhoi
Once this PR has been reviewed and has the lgtm label, please assign jichenjc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dulek and lentzi90 March 28, 2024 06:16
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 28, 2024

Hi @nguyenhuukhoi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 28, 2024

@nguyenhuukhoi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

What this PR does / why we need it: We need this option to use in case of having edge

This PR allows to choose AZ for API Load Balancer. It will be useful if we want to use edge sites,

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 2cb079c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660c9c396d05f20008d6ab7a
😎 Deploy Preview https://deploy-preview-1979--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huxcrux
Copy link
Contributor

huxcrux commented Mar 28, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2024
huxcrux
huxcrux reviewed Mar 29, 2024
View reviewed changes
Copy link
Contributor

@huxcrux huxcrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of functions in the conversion seems to break CI. We probably want to fix some kind of migration even if it is loosy?

api/v1alpha6/zz_generated.conversion.go
func Convert_v1beta1_APIServerLoadBalancer_To_v1alpha6_APIServerLoadBalancer(in *v1beta1.APIServerLoadBalancer, out *APIServerLoadBalancer, s conversion.Scope) error {
return autoConvert_v1beta1_APIServerLoadBalancer_To_v1alpha6_APIServerLoadBalancer(in, out, s)
}

Copy link
Contributor

@huxcrux huxcrux Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we want to remove this part since it is expected to exist. If anything fails a change in the migration might be needed

api/v1alpha7/zz_generated.conversion.go
Comment on lines -476 to -480
// Convert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer is an autogenerated conversion function.
func Convert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer(in *v1beta1.APIServerLoadBalancer, out *APIServerLoadBalancer, s conversion.Scope) error {
return autoConvert_v1beta1_APIServerLoadBalancer_To_v1alpha7_APIServerLoadBalancer(in, out, s)
}

Copy link
Contributor

@huxcrux huxcrux Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here we probably do not want to remove this function since it is in use

@dulek
Copy link
Contributor

dulek commented Apr 2, 2024

I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1

@nguyenhuukhoi
Copy link
Contributor Author

nguyenhuukhoi commented Apr 2, 2024 via email

@nguyenhuukhoi
Merge pull request #1 from dulek/nguyenhuukhoi/main
2cb079c 
Add opt to use AZ for APISeverLoadBalancer
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
@nguyenhuukhoi
Copy link
Contributor Author

nguyenhuukhoi commented Apr 2, 2024

/retest

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@nguyenhuukhoi
Copy link
Contributor Author

nguyenhuukhoi commented Apr 2, 2024

I took the freedom to try to fix this patch, please check out: nguyenhuukhoi#1

Hello. I do a mistake. Could you help me revert it?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 3, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 3, 2024

@nguyenhuukhoi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-build 2cb079c link true /test pull-cluster-api-provider-openstack-build
pull-cluster-api-provider-openstack-test 2cb079c link true /test pull-cluster-api-provider-openstack-test
pull-cluster-api-provider-openstack-e2e-test 2cb079c link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dulek dulek mentioned this pull request Apr 5, 2024
Merged
3 tasks
@dulek
Copy link
Contributor

dulek commented Apr 5, 2024

I submitted a new PR where I rebased this: #2004.

@mdbooth
Copy link
Contributor

mdbooth commented Apr 9, 2024

As noted, this commit has been rebased into PR #2004

@mdbooth mdbooth closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dulek dulek Awaiting requested review from dulek

@lentzi90 lentzi90 Awaiting requested review from lentzi90

1 more reviewer

@huxcrux huxcrux huxcrux left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

CAPO Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nguyenhuukhoi @k8s-ci-robot @huxcrux @dulek @mdbooth