Conversation
Going back to v1beta1 Signed-off-by: Nahshon Unna Tsameret <nahsh.ut@gmail.com>
…capi-api-to-beta1 Revert moving to claster-api v1beta2
Add support for exposing all IP addresses (IPv4 and IPv6) in the KubevirtMachine status instead of just the primary IP. This fixes CSR auto-approval on dual-stack hosted control plane clusters where the machine-approver needs to see both IPv4 and IPv6 addresses. Changes: - Add Addresses() method to MachineInterface to retrieve all IPs from all VMI network interfaces - Update controller to populate multiple InternalIP and ExternalIP entries for each address - Add unit tests for dual-stack address handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
[release-0.11] Expose dual-stack addresses in KubevirtMachine status
drainNode() was using vmiInstance.Status.EvacuationNodeName to look up the node in the guest cluster, but that field contains the host/infra node name. This caused the drain to silently fail with a NotFound error, meaning workloads were abruptly killed instead of being gracefully evicted. Use KubevirtMachine.Name instead, which is the guest node name, consistent with the rest of the codebase (e.g. updateNodeProviderID, GenerateProviderID). Update unit tests to use distinct values for the host node name and guest node name, so the bug cannot be masked again. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The eviction e2e test only validated that the VMI was deleted and recreated, but did not check that the guest node was actually drained. Add an assertion that the guest node is marked unschedulable (cordoned) before the VMI finalizer is removed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ction Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/XXL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by mistake