Bump cluster-api to v1.11.1 and support v1beta2 api

[changjjjjjjj]

What this PR does / why we need it:

• Bump cluster api version to v1.11.1
• Support cluster api v1beta2, especially for conditions (it changed from clusterv1.conditions to metav1.condition)
• module updates for CVEs
• Use golangci-lint v2 and fix all lint errors

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #321

Special notes for your reviewer:

Release notes:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: changjjjjjjj
Once this PR has been reviewed and has the lgtm label, please assign nunnatsa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[changjjjjjjj]

Hi @qinqon @nunnatsa, would you please check this PR since current CAPK doesn't work on the latest CAPI

[nunnatsa]

//ok-to-test

[nunnatsa]

/ok-to-test

[nunnatsa]

/override build/coverage

[nunnatsa]

/override "build / coverage"

[nunnatsa]

@changjjjjjjj it seems like the e2e test is broken. I'll try to fix it later today.

[nunnatsa]

/override "build / coverage (pull_request)"

[coveralls]

Pull Request Test Coverage Report for Build 17761358176

Details

• 109 of 205 (53.17%) changed or added relevant lines in 16 files are covered.
• 506 unchanged lines in 12 files lost coverage.
• Overall coverage decreased (-18.8%) to 40.14%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/kubevirtmachine_controller.go	81	82	98.78%
api/v1alpha1/kubevirtcluster_types.go	0	2	0.0%
api/v1alpha1/kubevirtmachine_types.go	0	2	0.0%
main.go	0	2	0.0%
pkg/workloadcluster/workloadcluster.go	0	2	0.0%
pkg/kubevirt/utils.go	7	10	70.0%
pkg/ssh/ssh_command_executor.go	0	5	0.0%
api/v1alpha1/zz_generated.deepcopy.go	0	6	0.0%
pkg/ssh/utils.go	0	7	0.0%
pkg/testing/common.go	0	8	0.0%

Files with Coverage Reduction	New Missed Lines	%
pkg/ssh/utils.go	1	51.47%
api/v1alpha1/kubevirtclustertemplate_types.go	3	0.0%
api/v1alpha1/kubevirtmachinetemplate_types.go	3	0.0%
api/v1alpha1/kubevirtcluster_types.go	7	0.0%
api/v1alpha1/kubevirtmachine_types.go	7	0.0%
pkg/context/cluster_context.go	10	0.0%
pkg/infracluster/mock/infracluster_generated.go	20	0.0%
pkg/workloadcluster/mock/workloadcluster_generated.go	30	0.0%
pkg/context/machine_context.go	32	0.0%
api/v1alpha1/zz_generated.deepcopy.go	99	0.0%

Totals
Change from base Build 16778497835:	-18.8%
Covered Lines:	1091
Relevant Lines:	2718

---

💛 - Coveralls

[nunnatsa]

Thanks for taking care of this, @changjjjjjjj

Added some inline comments.

[nunnatsa]

We do need this setting

[changjjjjjjj]

linter-settings option is migrated to settings. I added it again. Thanks

[changjjjjjjj]

Hi @nunnatsa, I'm having problem dealing with some e2e test cases.

1. [FAIL] CreateCluster [It] should remediate a running VMI marked as being in a terminal state [ephemeralVMs, terminal]: I think remediating with terminal label doesn't work. It only adds failureReason but doesn't delete VMI (I've tested it in v0.1.10 too).
2. [FAIL] CreateCluster [It] should remediate failed unrecoverable VMI [ephemeralVMs]
3. [FAIL] CreateCluster [It] creates a simple externally managed cluster ephemeral VMs [ephemeralVMs, externallyManaged]
   I have no idea with these two cases. In my environment, it works perfectly with CAPI v1.11.1.
   I would be glad if you give me some advice

[nunnatsa]

Hi @changjjjjjjj - I opened a new PR based on yours, and made some changes to make it work. It's now finally working.

Could you please review #328 ?

[nunnatsa]

Hi @changjjjjjjj - I opened a new PR based on yours, and made some changes to make it work. It's now finally working.

Could you please review #328 ?

Got LGTM. Thanks for your PR and hard work, @changjjjjjjj !!

[k8s-ci-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[changjjjjjjj]

@nunnatsa Thanks for the fixes. I will close this PR.