fix: load kustomize_substitutions before envsubst

[devigned]

What this PR does / why we need it:

With #829 the kustomize_substitutions in the tilt settings file were not being loaded into the env or replaced in the yaml before running envsubst. This PR fixes this problem by loading them into the env prior to executing envsubst via kustomizesub.

/cc @CecileRobertMichon and @jsturtevant

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

[k8s-ci-robot]

@devigned: GitHub didn't allow me to request PR reviews from the following users: and, jsturtevant.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

What this PR does / why we need it:

With #829 the kustomize_substitutions in the tilt settings file were not being loaded into the env or replaced in the yaml before running envsubst. This PR fixes this problem by loading them into the env prior to executing envsubst via kustomizesub.

/cc @CecileRobertMichon and @jsturtevant

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

that fixes the issue I was running into, thanks @devigned!
/approve

/assign @jsturtevant
James, can you please confirm it still work with his setup as well?

[k8s-ci-robot]

@CecileRobertMichon: GitHub didn't allow me to assign the following users: jsturtevant.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

that fixes the issue I was running into, thanks @devigned!
/approve

/assign @jsturtevant
James, can you please confirm it still work with his setup as well?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jsturtevant]

I confirmed it works in my set up.

/lgtm

[k8s-ci-robot]

@jsturtevant: changing LGTM is restricted to collaborators

Details

In response to this:

I confirmed it works in my set up.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CecileRobertMichon]

/lgtm