Handle large yaml files on linux in tilt config#829
Conversation
|
Hi @jsturtevant. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9d3b447 to
c367ab8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
…tes-sigs#829) Co-authored-by: Troy Connor <troy0820@users.noreply.github.com> Co-authored-by: Brian Chuo <110847365+bchuo@users.noreply.github.com>
What this PR does / why we need it:
make tilt-upbreaks on linux with message:This is because the file is echoed onto the command line
cluster-api-provider-azure/Tiltfile
Line 339 in bceee96
The amount of data in the
yamlstring is to much on linux (I am guessing this works on mac) but eventually someone on a mac might have run into this as the yaml grows with more features.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
The env sub command for the flavors works because the amount for a yaml is small.
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: