Skip to content

Handle large yaml files on linux in tilt config#829

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
jsturtevant:fix-tilt-up-on-linux
Jul 25, 2020
Merged

Handle large yaml files on linux in tilt config#829
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
jsturtevant:fix-tilt-up-on-linux

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

@jsturtevant jsturtevant commented Jul 24, 2020

What this PR does / why we need it:
make tilt-up breaks on linux with message:

error: fork/exec /usr/bin/sh: argument list too long"

This is because the file is echoed onto the command line

return str(local("echo \"{}\" | {}".format(yaml, envsubst_cmd), quiet=True))

The amount of data in the yaml string is to much on linux (I am guessing this works on mac) but eventually someone on a mac might have run into this as the yaml grows with more features.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:
The env sub command for the flavors works because the amount for a yaml is small.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

fix tilt-up argument list too long error on linux

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @jsturtevant. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Jul 24, 2020
@jsturtevant jsturtevant force-pushed the fix-tilt-up-on-linux branch from 9d3b447 to c367ab8 Compare July 24, 2020 23:38
Copy link
Copy Markdown
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devigned

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2020
@devigned
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9dec43b into kubernetes-sigs:master Jul 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v0.4.7 milestone Jul 25, 2020
willie-yao pushed a commit to willie-yao/cluster-api-provider-azure that referenced this pull request Jul 11, 2025
…tes-sigs#829)

Co-authored-by: Troy Connor <troy0820@users.noreply.github.com>
Co-authored-by: Brian Chuo <110847365+bchuo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants