Skip to content

Skip MEC e2e test#4900

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
mboersma:skip-mec-e2e-test
Jun 5, 2024
Merged

Skip MEC e2e test#4900
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
mboersma:skip-mec-e2e-test

Conversation

@mboersma
Copy link
Copy Markdown
Contributor

@mboersma mboersma commented Jun 5, 2024

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The edgezone this test depended on is being decommissioned, so it began failing. Since we know it won't pass, let's skip it for now until the Edge Zone team has had time to set up another edgezone with CAPZ reference images.

This is to get useful green signal for the -optional tests on PRs and on testgrid.

Which issue(s) this PR fixes:

Refs #4885

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2024
@mboersma
Copy link
Copy Markdown
Contributor Author

mboersma commented Jun 5, 2024

/cc @nojnhuh

@k8s-ci-robot k8s-ci-robot requested a review from nojnhuh June 5, 2024 18:14
@mboersma
Copy link
Copy Markdown
Contributor Author

mboersma commented Jun 5, 2024

/test pull-cluster-api-provider-azure-e2e-optional

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.19%. Comparing base (56259aa) to head (90de8bf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4900   +/-   ##
=======================================
  Coverage   62.19%   62.19%           
=======================================
  Files         201      201           
  Lines       16878    16878           
=======================================
  Hits        10497    10497           
  Misses       5591     5591           
  Partials      790      790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

/lgtm
/approve
/hold for optional tests

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f1d8595e552703235099db261e10aad9af511a14

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@nojnhuh
Copy link
Copy Markdown
Contributor

nojnhuh commented Jun 5, 2024

The MEC test is being skipped as expected and the only other failures are Windows-related which I think we already have a handle on.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 5, 2024

@mboersma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-optional 90de8bf link false /test pull-cluster-api-provider-azure-e2e-optional

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nojnhuh
Copy link
Copy Markdown
Contributor

nojnhuh commented Jun 5, 2024

/test pull-cluster-api-provider-azure-e2e-aks

@k8s-ci-robot k8s-ci-robot merged commit 9018639 into kubernetes-sigs:main Jun 5, 2024
@mboersma mboersma deleted the skip-mec-e2e-test branch June 5, 2024 23:06
@mboersma
Copy link
Copy Markdown
Contributor Author

mboersma commented Jun 5, 2024

/cherry-pick release-1.15

@mboersma
Copy link
Copy Markdown
Contributor Author

mboersma commented Jun 5, 2024

/cherry-pick release-1.14

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@mboersma: new pull request created: #4903

Details

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@mboersma: new pull request created: #4904

Details

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants