remove k8s version pin to 1.25 for MEC e2e test#4885
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
/cherry-pick release-1.14 /test pull-cluster-api-provider-azure-e2e-optional |
|
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4885 +/- ##
=======================================
Coverage 62.04% 62.04%
=======================================
Files 201 201
Lines 16878 16878
=======================================
Hits 10472 10472
Misses 5623 5623
Partials 783 783 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: d659d25b7ef67d088667c14926a78e688ff46cad |
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@mboersma It looks like this is complaining that the image doesn't exist specifically within this EdgeZone. I wonder if that's why the k8s version was originally pinned. Is there an easy way to copy the existing images to that particular region? I see that this command works from the CI sub: But this one which includes the EdgeZone doesn't: |
Not that I know of. When we publish to the Azure Marketplace, it takes care of "global" replication, which seems to mean availability in all public regions. There aren't any options in the Marketplace UI itself that allow configuration of EdgeZones or any other replication option. (I agree it seems likely this is why the test pinned the image.) I'll do some searching and see if I can find anything. |
|
Based on this comment I'm inferring that some out-of-band process had to happen to make that particular image available in the testing EdgeZone. @upxinxin is that correct? Do you know how we might make a newer CAPZ image available to this e2e test introduced in #2836? (BTW, I checked, and the 1.25.x images were all deprecated programmatically on May 25.) |
| replicas: ${WORKER_MACHINE_COUNT:=2} | ||
| selector: {} | ||
| selector: | ||
| matchLabels: null |
There was a problem hiding this comment.
Just wanted to clarify: Why is this change needed?
There was a problem hiding this comment.
That's what happened to get generated ¯\_(ツ)_/¯
There was a problem hiding this comment.
That's interesting.. I wonder what change prompted that 🤔
mboersma
removed
the
lgtm
|
Please disable this e2e test. |
|
|
looks like we can close this PR? |
|
@garogarabedyan Can we keep this test as long as we migrate off of the |
|
@jackfrancis In order to run this test going forward, we need to at least change the edge zone that the test is running in and also update the VM image used once we make it available in that new region. I think we can do those things in this PR yet. |
I think you can keep the source code of the test. I think you should not spend time to fix the test before disabling it. |
|
Closing until we can reenable the test. /close |
|
@nojnhuh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The
edgezonee2e test is failing, and I thought I saw somewhere that it's because the v1.25.0 image that this was pinned to before no longer exists but now I can't seem to find evidence of that. Regardless, v1.25 is EOL so we shouldn't be pinning to it anymore. I couldn't find any commentary on #2836 as to the reason for the 1.25 pin originally.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: