Skip to content

chore: add e2e test for byo public IP#627

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
nilo19:chore/test-byo-ip
May 26, 2021
Merged

chore: add e2e test for byo public IP#627
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
nilo19:chore/test-byo-ip

Conversation

@nilo19
Copy link
Copy Markdown
Contributor

@nilo19 nilo19 commented May 12, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind cleanup

What this PR does / why we need it:

chore: add e2e test for byo public IP

Which issue(s) this PR fixes:

Fixes #618

Special notes for your reviewer:

Release note:

chore: add e2e test for byo public IP

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2021
Comment thread tests/e2e/network/ensureloadbalancer.go Outdated
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2021
@nilo19 nilo19 changed the title chore: add e2e test for byo public IP [WIP] chore: add e2e test for byo public IP May 13, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
@nilo19 nilo19 changed the title [WIP] chore: add e2e test for byo public IP chore: add e2e test for byo public IP May 13, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2021
@nilo19 nilo19 requested a review from feiskyer May 25, 2021 13:11
Copy link
Copy Markdown
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d674525 into kubernetes-sigs:master May 26, 2021
@nilo19 nilo19 deleted the chore/test-byo-ip branch May 27, 2021 02:21
k8s-ci-robot added a commit that referenced this pull request Jan 10, 2022
Cherry-pick #607, #627 and #841 to branch release-0.7
@MartinForReal
Copy link
Copy Markdown
Contributor

/cherrypick release-1.0

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

@MartinForReal: #627 failed to apply on top of branch "release-1.0":

Applying: chore: add e2e test for byo public IP
Using index info to reconstruct a base tree...
M	site/content/en/topics/tagging-resources.md
M	tests/e2e/network/ensureloadbalancer.go
M	tests/e2e/network/service_annotations.go
M	tests/e2e/utils/network_utils.go
M	tests/e2e/utils/service_utils.go
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/utils/service_utils.go
Auto-merging tests/e2e/utils/network_utils.go
Auto-merging tests/e2e/network/service_annotations.go
CONFLICT (content): Merge conflict in tests/e2e/network/service_annotations.go
Auto-merging tests/e2e/network/ensureloadbalancer.go
CONFLICT (content): Merge conflict in tests/e2e/network/ensureloadbalancer.go
Auto-merging site/content/en/topics/tagging-resources.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 chore: add e2e test for byo public IP
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added a commit that referenced this pull request Apr 2, 2022
[release 1.0]Tests: e2e add multiport service test and backport #627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: enhance BYO public IP e2e test

5 participants