Skip to content

[release 1.0]Tests: e2e add multiport service test and backport #627#1398

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:release-1.0from
MartinForReal:release-1.0_backport_1370
Apr 2, 2022
Merged

[release 1.0]Tests: e2e add multiport service test and backport #627#1398
k8s-ci-robot merged 2 commits into
kubernetes-sigs:release-1.0from
MartinForReal:release-1.0_backport_1370

Conversation

@MartinForReal
Copy link
Copy Markdown
Contributor

@MartinForReal MartinForReal commented Apr 1, 2022

What type of PR is this?

/kind testing

What this PR does / why we need it:

We need to add e2e test case to cover the scenario in which a service with multiple ports is applied.

and backport #627

Which issue(s) this PR fixes:

Fixes #1318

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from andyzhangx April 1, 2022 10:00
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nilo19 April 1, 2022 10:00
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 1, 2022

Coverage Status

Coverage remained the same at 80.005% when pulling c75eb00 on MartinForReal:release-1.0_backport_1370 into 2f3c6a4 on kubernetes-sigs:release-1.0.

nilo19 and others added 2 commits April 1, 2022 10:43
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2022
@MartinForReal MartinForReal changed the title [release 1.0]Tests: e2e add multiport service test [release 1.0]Tests: e2e add multiport service test and backport #627 Apr 1, 2022
@feiskyer
Copy link
Copy Markdown
Member

feiskyer commented Apr 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit c2a1c8b into kubernetes-sigs:release-1.0 Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/testing lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants