Skip to content

chores: format go.mod and bump dependencies#1961

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
MartinForReal:shafan/updatedeps
Sep 12, 2023
Merged

chores: format go.mod and bump dependencies#1961
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
MartinForReal:shafan/updatedeps

Conversation

@MartinForReal
Copy link
Copy Markdown
Contributor

@MartinForReal MartinForReal commented Sep 11, 2023 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
chores: format go.mod and bump dependencies
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 11, 2023
@MartinForReal MartinForReal changed the title chores: bump go mod to 1.21 and update deps chores: format go.mod and bump dependencies Sep 11, 2023
andyzhangx
andyzhangx reviewed Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you make this change? could you provide the steps in the PR? thanks.

@MartinForReal
Copy link
Copy Markdown
Contributor Author

MartinForReal commented Sep 11, 2023

removed the second and the third require statements
ran go mod tidy and the command failed due to metric package not found
ran go mod graph and found that the failure was due to conflict in version of go.opentelemetry.io/otel
checked the status of k8s.io/component-base and added replace statements.
Then ran go mod tidy and it worked.

@MartinForReal
Copy link
Copy Markdown
Contributor Author

MartinForReal commented Sep 11, 2023

related: kubernetes-csi/csi-lib-utils#148

@MartinForReal
Copy link
Copy Markdown
Contributor Author

MartinForReal commented Sep 11, 2023

/retest

andyzhangx
andyzhangx approved these changes Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 12ad686 into kubernetes-sigs:master Sep 12, 2023
@MartinForReal MartinForReal deleted the shafan/updatedeps branch September 12, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@cvvz cvvz Awaiting requested review from cvvz

Assignees

@andyzhangx andyzhangx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinForReal @k8s-ci-robot @andyzhangx