Downgrade otelgrpc lib to resolve dependency conflict when k8s.io/component-base is imported.

[MartinForReal]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Downgrade otelgrpc lib to resolve dependency conflict when k8s.io/component-base is imported.

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.41.0 requires following libs

	go.opentelemetry.io/otel v1.16.0
	go.opentelemetry.io/otel/metric v1.16.0
	go.opentelemetry.io/otel/trace v1.16.0

where k8s.io/component-base requires a different version

https://github.com/kubernetes/component-base/blob/44f31b29cc46816113a74802aade8f3256483bee/go.mod#L20-L24

The developer needs to resolve dependency conflict(go.opentelemetry.io/otel,go.opentelemetry.io/otel/metric and etc) when k8s/component-base and github.com/kubernetes-csi/csi-lib-utils are imported(e.g. in csi plugin implementation).

I think it is a good idea to keep go.mod aligned with k8s.io/component-base because k8s.io/component-base is widely used.
If we import go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.36.2.
go.opentelemetry.io/otel will not be upgraded to 1.16. And dependency issue can be resolved.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc is downgrade to v0.36.2

[k8s-ci-robot]

Welcome @MartinForReal!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MartinForReal. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cvvz]

/ok-to-test

[k8s-ci-robot]

@cvvz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MartinForReal]

/assign @jsafrane

[MartinForReal]

/assign @jsafrane

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MartinForReal
Once this PR has been reviewed and has the lgtm label, please ask for approval from jsafrane. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/ok-to-test

[MartinForReal]

/assign @pohly

[pohly]

go.opentelemetry.io/otel v1.16.0
go.opentelemetry.io/otel/metric v1.16.0
go.opentelemetry.io/otel/trace v1.16.0

where k8s.io/component-base requires a different version

Why is that a conflict? These are v1 packages. Their API should not break between minor or patch releases. If csi-lib-utils pulls in more recent releases of these, then component-base should still work.

It feels like I am missing some piece of explanation.

[MartinForReal]

I agree if these dependencies work well when it is invoked in this project( e.g. in ut/e2e)
But when csi driver imports csi-lib-utils, otel and k8s.io/component-base, the developer should choose the correct version of otel which is compatible with csi-lib-utils and k8s.io/component-base. And sometimes it is not possible if otel introduces a break change in new release. So, it is a good idea to keep aligned with config in latest component-base release. Because there will be less dependency issue in csi driver.

[pohly]

Keeping otelgrpc the same as in component-base makes sense because it it is a v0 package and thus may have breaking changes. But that's not what your PR description says - it just talks about packages that it pulls in.

[MartinForReal]

What I actually mean is Keeping otelgrpc the same as in component-base.

[pohly]

This is not quite what current Kubernetes master is using:

go.mod: go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful v0.35.0
go.mod: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.35.0
....
go.mod: go.opentelemetry.io/otel/metric v0.31.0 // indirect

If the goal is to be aligned, why not use exactly the same versions?

[MartinForReal]

updated.

[MartinForReal]

this library is not imported in k8s.io/component-base. but glad to know it is imported in k/k. updated the pr

[msau42]

/hold

We were able to find a compatible version in kubernetes-csi/external-provisioner#1025

[MartinForReal]

@msau42 yes. We can find one by chance. But It is easier for all of the dependents because there is no need to resolve dependency conflict.

[jsafrane]

We use dependabot to update dependencies in most of kubernetes-csi repos. So otel / k8s.io/* are updated mostly randomly. Do we really lock them to their version from kubernetes/kubernetes? That would mean changing dependabot configs there + manually update our kubernetes-csi repos when Kubernetes bumps a dependency.

I am not against, but I kind of like dependabot + the latest releases (if new deps are not failing too much, which we saw with otel).