Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

Use json-iterator in Kubelet client. #1907

Merged
merged 2 commits into from
Dec 12, 2017
Merged

Use json-iterator in Kubelet client. #1907

merged 2 commits into from
Dec 12, 2017

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Dec 7, 2017

No description provided.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@piosz
Copy link
Contributor

piosz commented Dec 8, 2017

/retest

@piosz
Copy link
Contributor

piosz commented Dec 8, 2017

/lgtm
@wojtek-t PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2017
@piosz piosz closed this Dec 8, 2017
@piosz piosz reopened this Dec 8, 2017
@wojtek-t
Copy link

wojtek-t commented Dec 8, 2017

This looks fine.

@kawych @piosz - did you manage to run any benchmarks/load tests with this change?

@piosz
Copy link
Contributor

piosz commented Dec 8, 2017

Karol has some results.

@piosz
Copy link
Contributor

piosz commented Dec 8, 2017

/retest

@piosz
Copy link
Contributor

piosz commented Dec 8, 2017

/test pull-heapster-e2e

@kawych
Copy link
Contributor Author

kawych commented Dec 8, 2017

This is one of changes, the other is #1906. This alone doesn't impact performance significantly - the test with 100 nodes and 3k user pods shows no reduced memory usage and CPU usage reduced only slightly (20m vs 18m). This was on standalone instance of heapster.

@BenTheElder
Copy link

/retest

@piosz
Copy link
Contributor

piosz commented Dec 12, 2017

/lgtm

@kawych kawych merged commit 32a110d into kubernetes-retired:master Dec 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants